Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bury Error::description() #50163

Merged
merged 3 commits into from
Apr 30, 2018
Merged

Bury Error::description() #50163

merged 3 commits into from
Apr 30, 2018

Conversation

kornelski
Copy link
Contributor

@kornelski kornelski commented Apr 22, 2018 •
edited
Loading

Second attempt of #49536 rust-lang/rfcs#2230

The exact wording of the default implementation is still up in the air, but I think it's a detail that can be amended later.

@rust-highfive
Copy link
Collaborator

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:54:38] ....i......................................................................................test [run-pass] run-pass/mir_heavy_promoted.rs has been running for over 60 seconds
[00:54:43] .........
[00:55:15] ....................................................................................................
[00:55:44] ......................................................................ii............................
[00:56:37] .................................i....................................................i.ii.......test [run-pass] run-pass/saturating-float-casts.rs has been running for over 60 seconds
[00:57:20] ..............................................................................................iiiiii
[00:57:48] i...................................................................................................
[00:58:18] ....................................................................................................
[00:58:46] ....................................................................................................
---
[01:31:22] travis_fold:end:stage0-linkchecker

[01:31:22] travis_time:end:stage0-linkchecker:start=1524427076559403483,finish=1524427079421650858,duration=2862247375

[01:31:33] book/first-edition/print.html:12010: broken link fragment `#tymethod.description` pointing to `std/error/trait.Error.html`
[01:31:33] book/first-edition/error-handling.html:1372: broken link fragment `#tymethod.description` pointing to `std/error/trait.Error.html`
[01:31:41] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:31:41] 
[01:31:41] 
[01:31:41] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:31:41] expected success, got: exit code: 101
[01:31:41] expected success, got: exit code: 101
[01:31:41] 
[01:31:41] 
[01:31:41] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:31:41] Build completed unsuccessfully in 0:47:47
[01:31:41] make: *** [check] Error 1
[01:31:41] Makefile:58: recipe for target 'check' failed

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:54:26] ....i....................................................................................test [run-pass] run-pass/mir_heavy_promoted.rs has been running for over 60 seconds
[00:54:31] ...........
[00:55:04] ....................................................................................................
[00:55:34] ......................................................................ii............................
[00:56:26] .................................i....................................................i.ii......test [run-pass] run-pass/saturating-float-casts.rs has been running for over 60 seconds
[00:57:11] ..............................................................................................iiiiii
[00:57:39] i...................................................................................................
[00:58:09] ....................................................................................................
[00:58:35] ....................................................................................................
---
[01:31:18] travis_fold:end:stage0-linkchecker

[01:31:18] travis_time:end:stage0-linkchecker:start=1524433456208041777,finish=1524433459099048407,duration=2891006630

[01:31:28] book/unsized-types.html:46: broken link fragment `#dynamically-sized-types--sized` pointing to `book/second-edition/ch19-04-advanced-types.html`
[01:31:36] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:31:36] 
[01:31:36] 
[01:31:36] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:31:36] expected success, got: exit code: 101
[01:31:36] expected success, got: exit code: 101
[01:31:36] 
[01:31:36] 
[01:31:36] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:31:36] Build completed unsuccessfully in 0:47:55
[01:31:36] Makefile:58: recipe for target 'check' failed
[01:31:36] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1b687e4c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kornelski added a commit to kornelski/book that referenced this pull request Apr 23, 2018
@kornelski
Update link to match change in second edition
794c81b 
Blocks rust-lang/rust#50163
@Kimundi
Copy link
Member

Kimundi commented Apr 25, 2018

Seems fine, I'll r+ as soon as the tests pass.

SimonSapin and others added 2 commits April 25, 2018 21:54
@SimonSapin @kornelski
Move description of the Error trait to its own doc-comment
a5655b8 
… rather than the module’s.

Remove code definition of the Error trait from its doc-comment

It was out of date, and rustdoc already shows the same information.

Add a default impl for Error::description and document it as deprecated.

It is redundant with Display while being much less flexible for implementors.

This is only a "soft" deprecation: it is not worth the hassle of a warning to existing users.

Tweak Error trait docs to reflect actual requirements
@kornelski
Suggest alternatives to Error::description()
f6a833a
@kornelski
Copy link
Contributor Author

It passes the tests now

@pietroalbini
Copy link
Member

Ping from triage @Kimundi! The tests are passing now.

@Kimundi
Copy link
Member

Kimundi commented Apr 30, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Apr 30, 2018

📌 Commit 1912f39 has been approved by Kimundi

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2018
@bors
Copy link
Contributor

bors commented Apr 30, 2018

⌛ Testing commit 1912f39 with merge 4745092...

bors added a commit that referenced this pull request Apr 30, 2018
@bors
Auto merge of #50163 - kornelski:error, r=Kimundi
4745092 
Bury Error::description()

Second attempt of #49536 rust-lang/rfcs#2230

The exact wording of the default implementation is still up in the air, but I think it's a detail that can be amended later.
@bors
Copy link
Contributor

bors commented Apr 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Kimundi
Pushing 4745092 to master...

@bors bors merged commit 1912f39 into rust-lang:master Apr 30, 2018
@kornelski kornelski deleted the error branch April 30, 2018 17:35
@messense messense mentioned this pull request May 2, 2018
Merged
@alexcrichton alexcrichton mentioned this pull request May 3, 2018
Merged
@scottmcm scottmcm mentioned this pull request Jan 14, 2019
Closed
@alarsyo alarsyo mentioned this pull request Mar 26, 2020
Merged
niklasf added a commit to niklasf/ipnet that referenced this pull request May 26, 2021
@niklasf
Fix Error::description() deprecation warning
e9e6efc 
Deprecated since Rust 1.42.0, but does not require 1.42.0, because deprecation
has been prepared in rust-lang/rust#50163
by providing a default implementation.
@niklasf niklasf mentioned this pull request May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kimundi Kimundi

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kornelski @rust-highfive @Kimundi @pietroalbini @bors @SimonSapin