Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorings in preparation for the removal of the leak check #50397

Merged
merged 10 commits into from
May 4, 2018
Merged

Refactorings in preparation for the removal of the leak check #50397

merged 10 commits into from
May 4, 2018

Commits on May 2, 2018

  1. introduce UniverseIndex into InferCtxt 

    Always using root environment for now.
    @sgrif
    sgrif committed May 2, 2018
    Configuration menu
    Copy the full SHA
    df8f537 View commit details
    Browse the repository at this point in the history

  2. add universes to type inference variables 

    This gives each type inference variable a notion of universe but doesn't
do anything with it. We can always get the "current universe" from
infer_ctxt. This relies on the property of type variables that they can
never interact with siblings.
    @sgrif
    sgrif committed May 2, 2018
    Configuration menu
    Copy the full SHA
    e904d56 View commit details
    Browse the repository at this point in the history

  3. change skolemizations to use universe index 

    This is sort of confusing "side step". All it does is to change the
representation of a skolemized region. but the source of that universe
index is not the inference context, which is what we eventually want,
but rather an internal counter in the region inference context.

We'll patch that up later. But doing this now ought to help with
confusing diffs later.
    @sgrif
    sgrif committed May 2, 2018
    Configuration menu
    Copy the full SHA
    360cbf2 View commit details
    Browse the repository at this point in the history

  4. store RegionVariableInfo and not just RegionVariableOrigin

    @sgrif
    sgrif committed May 2, 2018
    Configuration menu
    Copy the full SHA
    6234a89 View commit details
    Browse the repository at this point in the history

  5. give a universe to region variables

    @sgrif
    sgrif committed May 2, 2018
    Configuration menu
    Copy the full SHA
    2f69b79 View commit details
    Browse the repository at this point in the history

  6. Fix rebase issues

    @sgrif
    sgrif committed May 2, 2018
    Configuration menu
    Copy the full SHA
    ce64f9d View commit details
    Browse the repository at this point in the history

  7. Wrap InferCtxt::universe in a cell 

    We'll need this in order to start tracking skolemizatoins here, and it's
easier to update all the field accesses now rather than later.
    @sgrif
    sgrif committed May 2, 2018
    Configuration menu
    Copy the full SHA
    f5d240b View commit details
    Browse the repository at this point in the history

  8. track skol levels in the InferCtxt rather than via counter

    @sgrif
    sgrif committed May 2, 2018
    Configuration menu
    Copy the full SHA
    04708ba View commit details
    Browse the repository at this point in the history

  9. Fix rebase issues

    @sgrif
    sgrif committed May 2, 2018
    Configuration menu
    Copy the full SHA
    4ac9717 View commit details
    Browse the repository at this point in the history

  10. Add a comment explaining unification w/ universes

    @sgrif
    sgrif committed May 2, 2018
    Configuration menu
    Copy the full SHA
    68a1fdf View commit details
    Browse the repository at this point in the history