Don't require clippy/miri for beta #50573
Conversation
rust-highfive
added
the
S-waiting-on-review
| # ignore $2 (branch id) | ||
| verify_status $3 $4 | ||
| else | ||
| if [ "$2" = beta ]; then |
There was a problem hiding this comment.
I think "beta" also here may want to be "beta_required"?
There was a problem hiding this comment.
so close, I tried elsif
There was a problem hiding this comment.
the "beta" here is the second arg to all function calls in status_check. It denotes the branch, not the kind of check. I should probably add more comments
| verify_status $3 $4 | ||
| else | ||
| if [ "$2" = beta ]; then | ||
| if grep -vq '"'"$1"'":"(test|build)-fail"' "$TOOLSTATE_FILE"; then |
There was a problem hiding this comment.
-
You should just use
-qhere. The-vflag means inverted search -
grepby default uses BRE which means you need to escape the brackets and vertical bars:if grep -q '"'"$1"'":"\(test\|build\)-fail"' "$TOOLSTATE_FILE"; then
or use
-Eto use ERE.
|
Awesome, thanks @oli-obk! |
|
Locally I'm getting if not on the nightly channel. |
|
@bors r+ Thanks! |
|
@bors r=kennytm added some docs |
|
🤔 bors is not seeing this PR. Closing and reopening. |
|
@bors r+ |
|
📌 Commit b817403 has been approved by |
bors
added
S-waiting-on-bors
Don't require clippy/miri for beta r? @kennytm cc @alexcrichton I'm trying this out locally atm to see if it works as I think it should. Not sure how to test it for real except wait for the next beta. fixes rust-lang#50557
Don't require clippy/miri for beta r? @kennytm cc @alexcrichton I'm trying this out locally atm to see if it works as I think it should. Not sure how to test it for real except wait for the next beta. fixes rust-lang#50557
Don't require clippy/miri for beta r? @kennytm cc @alexcrichton I'm trying this out locally atm to see if it works as I think it should. Not sure how to test it for real except wait for the next beta. fixes #50557
|
☀️ Test successful - status-appveyor, status-travis |
r? @kennytm
cc @alexcrichton
I'm trying this out locally atm to see if it works as I think it should. Not sure how to test it for real except wait for the next beta.
fixes #50557