Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clippy #50705

Merged
merged 1 commit into from
May 15, 2018
Merged

Update clippy #50705

merged 1 commit into from
May 15, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 13, 2018

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 13, 2018
@kennytm
Copy link
Member

kennytm commented May 14, 2018

@bors r+ p=1

@bors
Copy link
Contributor

bors commented May 14, 2018

📌 Commit 2b3c867 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented May 14, 2018

@bors r-

a new breaking PR snuck in: rust-lang/rust-clippy#2758

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 14, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented May 14, 2018

@bors r=kennytm p=1

@bors
Copy link
Contributor

bors commented May 14, 2018

📌 Commit 3a5b13a has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 14, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 14, 2018
@kennytm
Rollup merge of rust-lang#50705 - oli-obk:clippy, r=kennytm
9a629c2 
Update clippy

r? @Manishearth

@bors p=1
@kennytm kennytm mentioned this pull request May 14, 2018
Closed
@bors
Copy link
Contributor

bors commented May 15, 2018

⌛ Testing commit 3a5b13a with merge 308b7b0...

bors added a commit that referenced this pull request May 15, 2018
@bors
Auto merge of #50705 - oli-obk:clippy, r=kennytm
308b7b0 
Update clippy

r? @Manishearth

@bors p=1
@bors
Copy link
Contributor

bors commented May 15, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 308b7b0 to master...

@bors bors merged commit 3a5b13a into rust-lang:master May 15, 2018
@kennytm-githubbot
Copy link

📣 Toolstate changed by #50705!

Tested on commit 308b7b0.
Direct link to PR: #50705

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
💔 rls on windows: test-pass → build-fail (cc @nrc, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @nrc, @rust-lang/infra).

kennytm-githubbot added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 15, 2018
@kennytm-githubbot
📣 Toolstate changed by rust-lang/rust#50705!
bc18f16 
Tested on commit rust-lang/rust@308b7b0.
Direct link to PR: <rust-lang/rust#50705>

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
💔 rls on windows: test-pass → build-fail (cc @nrc, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @nrc, @rust-lang/infra).
@oli-obk oli-obk deleted the clippy branch May 15, 2018 04:50
@oli-obk
Copy link
Contributor Author

oli-obk commented May 15, 2018

Huh. How did that happen. Clippy should never cause rls to fail to build. Sorry. I'll fix in 3h

@oli-obk
Copy link
Contributor Author

oli-obk commented May 15, 2018

So rls downloads the clippy from crates.io, even though there's a path override in Cargo.toml. I must have screwed up the path override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rust-highfive @kennytm @bors @kennytm-githubbot @Manishearth