Miscellaneous changes to rustbuild and CI. #51459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conservatively only disable LLVM for rust-installer. This should shave 5 minutes from the x86_64-gnu-distcheck job by not building LLVM twice.
This should greatly reduce the commits on the rust-toolstate repository. `publish_toolstate.py` defaults to keep the old status if a new one is not found, so nothing needs to be changed to that file.
Use `./x.py build src/librustc_codegen_llvm` to build the codegen backend.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -343,7 +350,7 @@ tool!( | |||
| Compiletest, "src/tools/compiletest", "compiletest", Mode::ToolTest; | |||
| BuildManifest, "src/tools/build-manifest", "build-manifest", Mode::ToolStd; | |||
| RemoteTestClient, "src/tools/remote-test-client", "remote-test-client", Mode::ToolStd; | |||
| RustInstaller, "src/tools/rust-installer", "fabricate", Mode::ToolStd; | |||
| RustInstaller, "src/tools/rust-installer", "fabricate", Mode::ToolStd, llvm_tools = false; | |||
There was a problem hiding this comment.
What makes RustInstaller special? Can we add a comment?
There was a problem hiding this comment.
@Mark-Simulacrum Added a FIXME in ab5e3e6. The main reason is I've only verified RustInstaller can run without the LLVM binaries in $PATH (as the main purpose is to remove unnecessary work from distcheck).
|
@bors r+ I suspect that this is insufficient for much of a gain on CI, since we presumably are still building the llvm tools... unless I missed something. |
|
📌 Commit ab5e3e6 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 9, 2018
Miscellaneous changes to rustbuild and CI. 1. Don't build LLVM when running rust-installer. 2. If toolstate is unchanged, don't push a commit to the toolstate repo. 3. Allow `./x.py build src/librustc_codegen_llvm` 4. Added log to track #50887.
|
The LLVM dependency was pulled in by the |
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Jun 26, 2018
Do not build LLVM tools for any of the tools None of the tools in the list should need LLVM tools themselves as far as I can tell; if this is incorrect, we can re-enable the tool building later. The primary reason for doing this is that rust-central-station uses the BuildManifest tool and building LLVM there is not cached: it takes ~1.5 hours on the 2 core machine. This commit should make nightlies and stable releases much faster. Followup to #51459, r? @kennytm I'm mostly relying on CI to test this so probably don't roll it up; I'm not sure how to (and not particularly inclined to) wait for multiple hours to test this locally. I imagine that the failures should be fairly obvious when/if encountered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./x.py build src/librustc_codegen_llvmdist-x86_64-linux-alt#50887.