Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize the extra "LLVM tools versions" argument to build-manifest. #51703

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Jun 22, 2018

Fix #51699.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2018
@kennytm
Copy link
Member Author

kennytm commented Jun 22, 2018

r? @nrc cc @japaric

@rust-highfive rust-highfive assigned nrc and unassigned alexcrichton Jun 22, 2018
@mati865
Copy link
Contributor

mati865 commented Jun 22, 2018

It would nice to merge it today so next nightly installs properly (CI for many projects are broken today).
llvm-tools component can be fixed later.

@kennytm
Copy link
Member Author

kennytm commented Jun 22, 2018

We've got 14 hours to wait for review 🙃 (nightlies are released around UTC 00:00)

@nrc
Copy link
Member

nrc commented Jun 22, 2018

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 22, 2018

📌 Commit 07ad6e0 has been approved by nrc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jun 22, 2018
Recognize the extra "LLVM tools versions" argument to build-manifest.

Fix rust-lang#51699.
bors added a commit that referenced this pull request Jun 22, 2018
Rollup of 6 pull requests

Successful merges:

 - #51158 (Mention spec and indented blocks in doctest docs)
 - #51629 (Do not consume semicolon twice while parsing local statement)
 - #51637 (Update zx_cprng_draw_new on Fuchsia)
 - #51664 (make more libsyntax methods public)
 - #51666 (Disable probestack when GCOV profiling is being used)
 - #51703 (Recognize the extra "LLVM tools versions" argument to build-manifest.)

Failed merges:

r? @ghost
@bors bors merged commit 07ad6e0 into rust-lang:master Jun 22, 2018
@kennytm kennytm deleted the fix-51699 branch June 22, 2018 18:13
@ZhangHanDong
Copy link

✗ rustup update nightly
info: syncing channel updates for 'nightly-x86_64-apple-darwin'
info: latest update on 2018-06-22, rust version 1.28.0-nightly (662c70a59 2018-06-21)
info: downloading component 'rustc'
error: failed to parse url: 1.28.0-nightly (662c70a59 2018-06-21)/2018-06-22/rustc-nightly-x86_64-apple-darwin.tar.xz
info: caused by: relative URL without a base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants