Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowering cleanups [1/N] #51806

Merged
merged 18 commits into from
Jun 30, 2018
Merged

Lowering cleanups [1/N] #51806

merged 18 commits into from
Jun 30, 2018

Commits on Jun 27, 2018

  1. Cleanup in preparation of generic extraction

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    bdcace0 View commit details
    Browse the repository at this point in the history

  2. Generate the NodeId for existential type in the AST

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    b2e2c32 View commit details
    Browse the repository at this point in the history

  3. Don't generate a new NodeId for universal impl Trait

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    f8e83a6 View commit details
    Browse the repository at this point in the history

  4. Generate DefIds for impl Trait in the def_collector

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    013fca8 View commit details
    Browse the repository at this point in the history

  5. fixup

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    1b20242 View commit details
    Browse the repository at this point in the history

  6. Also place method impl trait into the surrounding module

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    2ec5eab View commit details
    Browse the repository at this point in the history

  7. Generate DefIds for the impl trait of async functions

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    9eb7561 View commit details
    Browse the repository at this point in the history

  8. Don't generate DefIds for impl trait in trait methods

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    62a5610 View commit details
    Browse the repository at this point in the history

  9. Update tests

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    d5efa96 View commit details
    Browse the repository at this point in the history

  10. Don't use println in the compiler

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    37cc714 View commit details
    Browse the repository at this point in the history

  11. Don't visit the impl Trait item twice

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    0e775a3 View commit details
    Browse the repository at this point in the history

  12. Fix rebase fallout

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    eb9043b View commit details
    Browse the repository at this point in the history

  13. Undo if let -> match conversion

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    a1f6a61 View commit details
    Browse the repository at this point in the history

  14. Document the make_ret_async argument's NodeId

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    a85b279 View commit details
    Browse the repository at this point in the history

  15. Add a convenience method for getting the impl Trait NodeId of an `I… 

    …sAysnc`
    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    5bd9eaa View commit details
    Browse the repository at this point in the history

  16. Deduplicate async's impl Trait id lowering

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    98a48fd View commit details
    Browse the repository at this point in the history

  17. Explain the lack of item recursion

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    f21a98d View commit details
    Browse the repository at this point in the history

  18. Update ui tests

    @oli-obk
    oli-obk committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    99575b5 View commit details
    Browse the repository at this point in the history