Update clippy #52562

Manishearth · 2018-07-20T07:55:09Z

rust-highfive · 2018-07-20T07:55:13Z

Warning

These commits modify submodules.

rust-highfive · 2018-07-20T08:02:41Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

###################################                                       49.5%
######################################################################## 100.0%
[00:01:25] extracting /checkout/obj/build/cache/2018-07-13/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:25]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:48] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:48] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:48] make: *** [prepare] Error 1
[00:01:48] Makefile:81: recipe for target 'prepare' failed
[00:01:49] Command failed. Attempt 2/5:
[00:01:49]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:49]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:49] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:49] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:49] make: *** [prepare] Error 1
[00:01:49] Makefile:81: recipe for target 'prepare' failed
[00:01:51] Command failed. Attempt 3/5:
[00:01:51]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:51]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:52] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:52] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:52] Makefile:81: recipe for target 'prepare' failed
[00:01:52] make: *** [prepare] Error 1
[00:01:55] Command failed. Attempt 4/5:
[00:01:55]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:55]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:56] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:56] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:56] Makefile:81: recipe for target 'prepare' failed
[00:01:56] make: *** [prepare] Error 1
[00:02:00] Command failed. Attempt 5/5:
[00:02:00]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:00]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:00] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:00] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:00] make: *** [prepare] Error 1
[00:02:00] Makefile:81: recipe for target 'prepare' failed
[00:02:00] The command has failed after 5 attempts.
travis_time:end:057d05f3:start=1532073589498275237,finish=1532073716333599863,duration=126835324626
---
travis_time:end:0374be99:start=1532073716721943213,finish=1532073716734478164,duration=12534951
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:031bca2b
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:09441980
travis_time:start:09441980
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1621fe06
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-07-20T14:43:51Z

@bors r+ p=14

bors · 2018-07-20T14:43:52Z

📌 Commit 826bec3 has been approved by kennytm

@kennytm

Update clippy r? @kennytm @oli-obk

bors · 2018-07-20T16:02:36Z

⌛ Testing commit 826bec3 with merge 77a6ee663a72063a5b16210c1e1698cbb98a9f87...

bors · 2018-07-20T17:16:29Z

💔 Test failed - status-appveyor

Manishearth · 2018-07-20T17:20:46Z

I suspect the macro checks PR broke this

RalfJung · 2018-07-21T09:58:45Z

Any chance of getting this in today so that we can get a new nightly again? :D

RalfJung · 2018-07-21T10:25:09Z

src/librustc/lint/builtin.rs

@@ -216,7 +217,8 @@ declare_lint! {
 declare_lint! {
    pub DEPRECATED,
    Warn,
-    "detects use of deprecated items"
+    "detects use of deprecated items",
+    report_in_external_macro


I had to read the macro definition to understand that "report_in_external_macro" is essentially a keyword here, and not an identifier. Is there a nicer way to do this? Maybe report_in_external_macro : true?

oli-obk · 2018-07-21T10:36:56Z

@bors r=RalfJung p=1

bors · 2018-07-21T10:36:57Z

📌 Commit 2f7edcc has been approved by RalfJung

bors · 2018-07-21T12:32:23Z

⌛ Testing commit 2f7edcc with merge 606713f...

@kennytm

Update clippy r? @kennytm @oli-obk

Manishearth · 2018-07-21T12:35:01Z

I don't really see a problem with that, macros invent local keywords all the time. Warn is like that too.

bors · 2018-07-21T14:37:40Z

☀️ Test successful - status-appveyor, status-travis
Approved by: RalfJung
Pushing 606713f to master...

rust-highfive · 2018-07-21T14:39:38Z

📣 Toolstate changed by #52562!

Tested on commit 606713f.
Direct link to PR: #52562

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.

Tested on commit rust-lang/rust@606713f. Direct link to PR: <rust-lang/rust#52562> 🎉 clippy-driver on windows: build-fail → test-pass. 🎉 clippy-driver on linux: build-fail → test-pass. 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass.

rust-highfive assigned kennytm Jul 20, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2018

Manishearth force-pushed the clippyup branch from 4eb0af0 to 826bec3 Compare July 20, 2018 08:15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2018

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jul 20, 2018

Rollup merge of rust-lang#52562 - Manishearth:clippyup, r=kennytm

5407f1c

Update clippy r? @kennytm @oli-obk

pietroalbini mentioned this pull request Jul 20, 2018

Rollup of 8 pull requests #52570

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 20, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2018

Manishearth and others added 3 commits July 20, 2018 20:58

Update clippy

d63e925

Allow individual lints to opt into being reported in external macros

b6e0547

Clippy opts out of in_external_macro

d3c1e2f

oli-obk force-pushed the clippyup branch from 826bec3 to d3c1e2f Compare July 20, 2018 20:50

RalfJung reviewed Jul 21, 2018

View reviewed changes

oli-obk mentioned this pull request Jul 21, 2018

Failing tests caused by rust-lang/rust#52467 rust-lang/rust-clippy#2947

Closed

Don't invent new magic keywords

2f7edcc

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2018

bors added a commit that referenced this pull request Jul 21, 2018

Auto merge of #52562 - Manishearth:clippyup, r=RalfJung

606713f

Update clippy r? @kennytm @oli-obk

bors merged commit 2f7edcc into rust-lang:master Jul 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update clippy #52562

Update clippy #52562

Manishearth commented Jul 20, 2018

rust-highfive commented Jul 20, 2018

rust-highfive commented Jul 20, 2018

kennytm commented Jul 20, 2018

bors commented Jul 20, 2018

bors commented Jul 20, 2018

bors commented Jul 20, 2018

Manishearth commented Jul 20, 2018

RalfJung commented Jul 21, 2018

RalfJung Jul 21, 2018 •

edited

Loading

oli-obk commented Jul 21, 2018

bors commented Jul 21, 2018

bors commented Jul 21, 2018

Manishearth commented Jul 21, 2018

bors commented Jul 21, 2018

rust-highfive commented Jul 21, 2018

Update clippy #52562

Update clippy #52562

Conversation

Manishearth commented Jul 20, 2018

rust-highfive commented Jul 20, 2018

rust-highfive commented Jul 20, 2018

kennytm commented Jul 20, 2018

bors commented Jul 20, 2018

bors commented Jul 20, 2018

bors commented Jul 20, 2018

Manishearth commented Jul 20, 2018

RalfJung commented Jul 21, 2018

RalfJung Jul 21, 2018 • edited Loading

Choose a reason for hiding this comment

oli-obk commented Jul 21, 2018

bors commented Jul 21, 2018

bors commented Jul 21, 2018

Manishearth commented Jul 21, 2018

bors commented Jul 21, 2018

rust-highfive commented Jul 21, 2018

RalfJung Jul 21, 2018 •

edited

Loading