Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run-pass/simd-intrinsic-float-minmax: Force use of qNaN on Mips #52895

Merged
merged 1 commit into from
Aug 14, 2018
Merged

run-pass/simd-intrinsic-float-minmax: Force use of qNaN on Mips #52895

merged 1 commit into from
Aug 14, 2018

Conversation

draganmladjenovic
Copy link
Contributor

@draganmladjenovic draganmladjenovic commented Jul 31, 2018 •
edited
Loading

Workaround for #52746.
r? @gnzlbg

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2018
@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 31, 2018

LGTM. I've opened #52897 to track one of the issues raised in #52746 .

@draganmladjenovic
Copy link
Contributor Author

draganmladjenovic commented Aug 13, 2018 •
edited
Loading

r? @gnzlbg

Sorry my first assignment change didn't get picked up. I don't think I have sufficient rights to merge this anyway, so assigning this to you.

@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 13, 2018 •
edited
Loading

cc @alexcrichton - the problem here is that the bitpattern used for NAN is a QNAN in most archs, but an SNAN on mips and that breaks this test for the time being. It is currently unclear in LLVM which semantics min and max should have w.r.t. SNAN, so we'll revisit this when that is resolved (see #52897 ).

In the mean time, this test breaking blocks further work on MIPS64 support.

@alexcrichton
Copy link
Member

@bors: r+

This is fine for now yeah, but definitely seems like something to sort before stabilization!

@bors
Copy link
Contributor

bors commented Aug 14, 2018

📌 Commit 78a1c45 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Aug 14, 2018
@kennytm
Rollup merge of rust-lang#52895 - draganmladjenovic:minmax_qnan, r=al…
c80cf1a 
…excrichton

run-pass/simd-intrinsic-float-minmax: Force use of qNaN on Mips

Workaround for rust-lang#52746.
@kennytm kennytm mentioned this pull request Aug 14, 2018
Closed
@bors
Copy link
Contributor

bors commented Aug 14, 2018

⌛ Testing commit 78a1c45 with merge a8763b5...

bors added a commit that referenced this pull request Aug 14, 2018
@bors
Auto merge of #52895 - draganmladjenovic:minmax_qnan, r=alexcrichton
a8763b5 
run-pass/simd-intrinsic-float-minmax: Force use of qNaN on Mips

Workaround for #52746.
r? @gnzlbg
@bors
Copy link
Contributor

bors commented Aug 14, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a8763b5 to master...

@bors bors merged commit 78a1c45 into rust-lang:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@draganmladjenovic @rust-highfive @gnzlbg @alexcrichton @bors @aturon