Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper_ctypes lint for individual foreign items #53100

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Fix improper_ctypes lint for individual foreign items #53100

merged 1 commit into from
Aug 9, 2018

Conversation

VPashkov
Copy link
Contributor

@VPashkov VPashkov commented Aug 6, 2018

Fixes #52456.

r? @eddyb

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2018
@eddyb
Copy link
Member

eddyb commented Aug 6, 2018

@bors r+ Thanks!

@bors
Copy link
Contributor

bors commented Aug 6, 2018

📌 Commit 70cafec has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2018
cramertj added a commit to cramertj/rust that referenced this pull request Aug 8, 2018
…s, r=eddyb

Fix improper_ctypes lint for individual foreign items

Fixes rust-lang#52456.

r? @eddyb
cramertj added a commit to cramertj/rust that referenced this pull request Aug 8, 2018
…s, r=eddyb

Fix improper_ctypes lint for individual foreign items

Fixes rust-lang#52456.

r? @eddyb
cramertj added a commit to cramertj/rust that referenced this pull request Aug 8, 2018
…s, r=eddyb

Fix improper_ctypes lint for individual foreign items

Fixes rust-lang#52456.

r? @eddyb
cramertj added a commit to cramertj/rust that referenced this pull request Aug 8, 2018
…s, r=eddyb

Fix improper_ctypes lint for individual foreign items

Fixes rust-lang#52456.

r? @eddyb
@bors
Copy link
Contributor

bors commented Aug 9, 2018

⌛ Testing commit 70cafec with merge 76b69a6...

bors added a commit that referenced this pull request Aug 9, 2018
Fix improper_ctypes lint for individual foreign items

Fixes #52456.

r? @eddyb
@bors
Copy link
Contributor

bors commented Aug 9, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 76b69a6 to master...

@bors bors merged commit 70cafec into rust-lang:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants