Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: collect trait impls as an early pass #53162

Merged
merged 20 commits into from
Sep 20, 2018
Merged

rustdoc: collect trait impls as an early pass #53162

merged 20 commits into from
Sep 20, 2018

Commits on Sep 20, 2018

  1. rustdoc: collect trait impls as an early pass

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    02bea3c View commit details
    Browse the repository at this point in the history

  2. print local inlined consts via the HIR map

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    5e0f9be View commit details
    Browse the repository at this point in the history

  3. ignore rustdoc/doc-proc-macro on stage1

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    457efc1 View commit details
    Browse the repository at this point in the history

  4. only move access_levels/external_traits after early passes

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    6aa7493 View commit details
    Browse the repository at this point in the history

  5. don't record an external trait if it's not external

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    804a1a6 View commit details
    Browse the repository at this point in the history

  6. undo some tweaks to build_impl

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    50fa16f View commit details
    Browse the repository at this point in the history

  7. add a bunch of debug prints

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    a893117 View commit details
    Browse the repository at this point in the history

  8. handle local names when registering FQNs

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    bfd2b34 View commit details
    Browse the repository at this point in the history

  9. pull local types from the HIR instead of tcx

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    978c13a View commit details
    Browse the repository at this point in the history

  10. collect impl items from the HIR if available

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    fe26efe View commit details
    Browse the repository at this point in the history

  11. pull impl generics from HIR if available

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    de6a897 View commit details
    Browse the repository at this point in the history

  12. swap external_traits into the crate before running strip_hidden

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    a45d387 View commit details
    Browse the repository at this point in the history

  13. don't check visibility when inlining local impls 

    those get handled properly in strip-hidden anyway
    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    e79780f View commit details
    Browse the repository at this point in the history

  14. add more tests for traits-in-non-module-scope

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    7e70fee View commit details
    Browse the repository at this point in the history

  15. don't index trait impls if the trait isn't also documented

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    e854d39 View commit details
    Browse the repository at this point in the history

  16. collect auto-/blanket-impls during collect-trait-impls

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    87760e5 View commit details
    Browse the repository at this point in the history

  17. refactor: move access_levels into RenderInfo

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    c754e82 View commit details
    Browse the repository at this point in the history

  18. shuffle ownership of external_traits 

    constraints:

- clean/inline.rs needs this map to fill in traits when inlining
- fold.rs needs this map to allow passes to fold trait items
- html/render.rs needs this map to seed the Cache.traits map of all
  known traits

The first two are the real problem, since `DocFolder` only operates on
`clean::Crate` but `clean/inline.rs` only sees the `DocContext`. The
introduction of early passes means that these two now exist at the same
time, so they need to share ownership of the map. Even better, the use
of `Crate` in a rustc thread pool means that it needs to be Sync, so it
can't use `Lrc<Lock>` to manually activate thread-safety.

`parking_lot` is reused from elsewhere in the tree to allow use of its
`ReentrantMutex`, as the relevant parts of rustdoc are still
single-threaded and this allows for easier use in that context.
    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    354507e View commit details
    Browse the repository at this point in the history

  19. filter collected trait impls against items in the crate

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    755c02d View commit details
    Browse the repository at this point in the history

  20. fix intra-links for trait impls

    @QuietMisdreavus
    QuietMisdreavus committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    1106577 View commit details
    Browse the repository at this point in the history