Whitelist wasm32 simd128 target feature #53179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors: r+ rollup |
|
📌 Commit 2cdaf3b has been approved by |
bors
added
S-waiting-on-bors
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
Whitelist wasm32 simd128 target feature r? @alexcrichton
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
Whitelist wasm32 simd128 target feature r? @alexcrichton
This was referenced Aug 8, 2018
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
Whitelist wasm32 simd128 target feature r? @alexcrichton
|
It looks like the target_feature gate test failed during a rollup: #53197 (comment) |
|
Damn, sorry about that. I forgot to update the |
|
No worries! Thanks for the quick fix :) @bors r=alexcrichton |
|
📌 Commit c92db36 has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 9, 2018
Whitelist wasm32 simd128 target feature r? @alexcrichton
bors
added a commit
that referenced
this pull request
Aug 9, 2018
Rollup of 15 pull requests Successful merges: - #52773 (Avoid unnecessary pattern matching against Option and Result) - #53082 (Fix doc link (again)) - #53094 (Automatically expand section if url id point to one of its component) - #53106 (atomic ordering docs) - #53110 (Account for --remap-path-prefix in save-analysis) - #53116 (NetBSD: fix signedess of char) - #53179 (Whitelist wasm32 simd128 target feature) - #53183 (Suggest comma when missing in macro call) - #53207 (Add individual docs for rotate_{left, right}) - #53211 ([nll] enable feature(nll) on various crates for bootstrap) - #53214 ([nll] enable feature(nll) on various crates for bootstrap: part 2) - #53215 (Slightly refactor syntax_ext/format) - #53217 (inline some short functions) - #53219 ([nll] enable feature(nll) on various crates for bootstrap: part 3) - #53222 (A few cleanups for rustc_target)
|
\o/ |
|
FYI this just means that rustc accepts the feature in all important places. LLVM cannot properly generate code for most (all?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton