Remove Travis shutdown debug scripts, and remove CI-specific DNS settings #53234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
(I just ignored tidy since I expect this PR would be quickly reverted after Travis got what they need.) |
|
@bors: r+ p=1 |
|
📌 Commit 548619ad781f576163e98072cfa5da98e472db21 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 548619ad781f576163e98072cfa5da98e472db21 with merge 235f85f17cf60cbc91b8e4fe78c9debd7dd47fc3... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@bors r=alexcrichton |
|
📌 Commit 212fd930424387063fce094386a17f4f6e7d07a2 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 212fd930424387063fce094386a17f4f6e7d07a2 with merge 2403f83feea6b804fb79a240f6e682a530c8fc57... |
|
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-review
kennytm
force-pushed
the
debug-9696
branch
4 times, most recently
from
a501452
to
619301c
Compare
bors
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
kennytm
added
S-waiting-on-author
|
Spurious, but I'll like to hold off merging the final commit for now. |
kennytm
changed the title
|
(TODO: Someone issue a |
|
@bors try |
|
⌛ Trying commit 536ade5b869522b9c37380c0aaa63d1e87cb58b4 with merge 764a55157c75f2986f74392ab0544d8a2a3bf41d... |
|
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
kennytm
changed the title
kennytm
added
S-waiting-on-review
|
I've extracted the DNS logs wanted by Travis, and thus the debugging code is removed from this PR now. This PR now only reverts #53134 and #53035. I've also reverted half of #51420 so we'll use the default DNS again. |
|
@bors: r+ |
|
📌 Commit b75f1ba has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=0 rollup |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 16, 2018
Remove Travis shutdown debug scripts, and remove CI-specific DNS settings Since the cause of the host shutdown (travis-ci/travis-ci#4924) is found, we could revert the shutdown debug attempts to shorten the logs. Additionally, we're pretty sure a custom DNS (added in will not help travis-ci/travis-ci#9696, so reverting that part of rust-lang#51420 to reduce CI-specific settings.
bors
added a commit
that referenced
this pull request
Aug 16, 2018
Rollup of 10 pull requests Successful merges: - #52946 (Documented impl From on line 367 of libserialize/json.rs) - #53234 (Remove Travis shutdown debug scripts, and remove CI-specific DNS settings) - #53313 (Two small improvements) - #53360 (Addressed #51602) - #53364 (Warn if the user tries to use GATs) - #53373 (Tweak unclosed delimiter parser error) - #53377 (std: Use target_pointer_width for BACKTRACE_ELF_SIZE) - #53395 (Use #[non_exhaustive] on internal enums) - #53399 (Tidy: ignore non-Markdown files when linting for the Unstable Book) - #53412 (syntax_ext: remove leftover span_err_if_not_stage0 macro.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the cause of the host shutdown (travis-ci/travis-ci#4924) is found, we could revert the shutdown debug attempts to shorten the logs.
Additionally, we're pretty sure a custom DNS (added in will not help travis-ci/travis-ci#9696, so reverting that part of #51420 to reduce CI-specific settings.