Show that Command can be reused and remodified #53264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
That's pretty cool, thanks! @bors: r+ rollup |
|
📌 Commit 678676c7562ac9b0402d5509dd7148178d56b051 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- (It hasn't gone through the test suite locally, and I don't want to break the rollup) |
|
@Havvy: 🔑 Insufficient privileges: Not in reviewers |
|
(please ping me or someone else with r+ rights once CI passed) @bors: r- |
bors
added
S-waiting-on-author
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The prior documentation did not make it clear this was possible.
src/libstd/process.rs
Outdated
| /// | ||
| /// let mut echo_hello = Command::new("sh"); | ||
| /// echo_hello.arg("-c") | ||
| /// .arg("echo hello"); |
There was a problem hiding this comment.
Please fix indent (one extra whitespace).
|
@GuillaumeGomez Awaiting your r+ now. |
|
Thanks! @bors: r+ rollup |
|
📌 Commit 0070b46 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 12, 2018
Show that Command can be reused and remodified The prior documentation did not make it clear this was possible. I wanted to make the `list_dir` example work on Windows, but I don't know if passing "/" will error or show the root of the current volume (e.g. `C:`).
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 12, 2018
Show that Command can be reused and remodified The prior documentation did not make it clear this was possible. I wanted to make the `list_dir` example work on Windows, but I don't know if passing "/" will error or show the root of the current volume (e.g. `C:`). r? @GuillaumeGomez
bors
added a commit
that referenced
this pull request
Aug 12, 2018
Rollup of 15 pull requests Successful merges: - #52955 (Update compiler test documentation) - #53019 (Don't collect() when size_hint is useless) - #53025 (Consider changing assert! to debug_assert! when it calls visit_with) - #53059 (Remove explicit returns where unnecessary) - #53165 ( Add aarch64-unknown-netbsd target) - #53210 (Deny future duplication of rustc-ap-syntax) - #53223 (A few cleanups for rustc_data_structures) - #53230 ([nll] enable feature(nll) on various crates for bootstrap: part 4) - #53231 (Add let keyword doc) - #53240 (Add individual documentation for <integer>`.swap_bytes`/.`reverse_bits`) - #53253 (Remove unwanted console log) - #53264 (Show that Command can be reused and remodified) - #53267 (Fix styles) - #53273 (Add links to std::char::REPLACEMENT_CHARACTER from docs.) - #53283 (wherein we suggest float for integer literals where a float was expected) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior documentation did not make it clear this was possible.
I wanted to make the
list_direxample work on Windows, but I don't know if passing "/" will error or show the root of the current volume (e.g.C:).r? @GuillaumeGomez