Prevent duplicated impl on foreign types #53801
Conversation
rust-highfive
added
the
S-waiting-on-review
|
Is there a way we can reproduce this so we can test it? The change is small enough that it looks fine (though i wonder if there's a deeper issue causing those duplicates to get added in the first place) but i'm hesitant to take it on its own. |
|
(Closed by accident, oops...) |
|
The issue is actually "easy": the Also for the test, the better one would be the UI one. I'm waiting for it to be merged before adding test for this fix. Do you want me to open an issue for it? |
|
Isn't there a way we can use a |
|
It is, just thought it wasn't a great idea. |
|
If you think you can get a better test in later on, then i guess it's fine. @bors r+ rollup |
|
📌 Commit 3b98571 has been approved by |
bors
added
S-waiting-on-bors
…ype-impls, r=QuietMisdreavus Prevent duplicated impl on foreign types Fixes rust-lang#53689. r? @QuietMisdreavus
Rollup of 9 pull requests Successful merges: - #53076 (set cfg(rustdoc) when rustdoc is running on a crate) - #53622 (cleanup: Add main functions to some UI tests) - #53769 (Also link Clippy repo in the CONTRIBUTING.md file) - #53774 (Add rust-gdbgui script.) - #53781 (bench: libcore: fix build failure of any.rs benchmark (use "dyn Any")) - #53782 (Make Arc cloning mechanics clearer in module docs) - #53790 (Add regression test for issue #52060) - #53801 (Prevent duplicated impl on foreign types) - #53850 (Nuke the `const_to_allocation` query)
…etMisdreavus rustdoc: Remove generated blanket impls from trait pages rust-lang#53801 only deduped the generated blanket impls but they shouldn't be displayed at all because the original blanket impl is already in the "Implementors" section. This also removes the impls from the sidebar. Fixes rust-lang#53689 r? @QuietMisdreavus
Fixes #53689.
r? @QuietMisdreavus