[rustdoc] Specific crate search #54706
Conversation
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
specifi-crate-search
branch
from
823847e
to
2a98c92
Compare
|
@QuietMisdreavus: You can see it in action here: http://gtk-rs.org/docs/gtk/struct.Window.html |
There was a problem hiding this comment.
Wow, this is nice! I think it'd be ideal if it was using the sans-serif font. (And as a bonus, could it also have a little magnifying glass icon? Something like https://www.fileformat.info/info/unicode/char/1f50d/index.htm, i guess. It seems like a little touch that would make it nicer.)
| @@ -1376,8 +1385,13 @@ | |||
| var ret_in_args = addTab(results['in_args'], query, false); | |||
| var ret_returned = addTab(results['returned'], query, false); | |||
|
|
|||
| var filter = ""; | |||
| if (filterCrates !== undefined) { | |||
| filter = " (in <b>" + filterCrates + "</b> crate)"; | |||
There was a problem hiding this comment.
Small wording nit:
| filter = " (in <b>" + filterCrates + "</b> crate)"; | |
| filter = " (in crate <b>" + filterCrates + "</b>)"; |
|
It's complicated because it takes already a lot of space and I'm worried that it might be an issue on mobile devices. However I intend to put arrows on the right of the (heavily modified) select box. That might help a bit. |
|
☔ The latest upstream changes (presumably #55171) made this pull request unmergeable. Please resolve the merge conflicts. |
TimNN
added
S-waiting-on-author
|
Re-review note: the wording nit still stands, and there's now a merge conflict. It's okay if we can't include the little icon, but can we still use the sans-serif font? I feel like it would be better to use it there, since it's in more of a "heading" position than a "body text" position, where we use the serif font currently.
|
|
Sure, I didn't come back to this PR yet. :) |
|
Ping from triage @GuillaumeGomez! |
|
Still the same. |
|
Ping from triage! This PR hasn't made any progress in a while, so I'm closing it per our triage guidelines. Thanks for your contributions and please feel free to re-open in the future. |
TimNN
added
S-inactive
|
I added the arrow as you can see here:
|
…, r=QuietMisdreavus [rustdoc] Specific crate search Reopening of rust-lang#54706. Fixes rust-lang#54616. <img width="1440" alt="screenshot 2018-11-29 at 01 29 11" src="https://user-images.githubusercontent.com/3050060/49191372-979adf80-f376-11e8-963e-e4feb927c1da.png"> r? @QuietMisdreavus
…, r=QuietMisdreavus [rustdoc] Specific crate search Reopening of rust-lang#54706. Fixes rust-lang#54616. <img width="1440" alt="screenshot 2018-11-29 at 01 29 11" src="https://user-images.githubusercontent.com/3050060/49191372-979adf80-f376-11e8-963e-e4feb927c1da.png"> r? @QuietMisdreavus
…, r=QuietMisdreavus [rustdoc] Specific crate search Reopening of rust-lang#54706. Fixes rust-lang#54616. <img width="1440" alt="screenshot 2018-11-29 at 01 29 11" src="https://user-images.githubusercontent.com/3050060/49191372-979adf80-f376-11e8-963e-e4feb927c1da.png"> r? @QuietMisdreavus
…, r=QuietMisdreavus [rustdoc] Specific crate search Reopening of rust-lang#54706. Fixes rust-lang#54616. <img width="1440" alt="screenshot 2018-11-29 at 01 29 11" src="https://user-images.githubusercontent.com/3050060/49191372-979adf80-f376-11e8-963e-e4feb927c1da.png"> r? @QuietMisdreavus
…, r=QuietMisdreavus [rustdoc] Specific crate search Reopening of rust-lang#54706. Fixes rust-lang#54616. <img width="1440" alt="screenshot 2018-11-29 at 01 29 11" src="https://user-images.githubusercontent.com/3050060/49191372-979adf80-f376-11e8-963e-e4feb927c1da.png"> r? @QuietMisdreavus
Fixes #54616
r? @QuietMisdreavus