Add BufWriter::buffer method #55211
Merged
Add BufWriter::buffer method #55211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@shepmaster Does this PR look reasonable? |
sfackler
reviewed
Oct 24, 2018
src/libstd/io/buffered.rs
Outdated
| /// ``` | ||
| #[unstable(feature = "bufreader_buffer", issue = "45323")] | ||
| pub fn buffer(&self) -> &[u8] { | ||
| &self.buf[..] |
There was a problem hiding this comment.
Nit: This can just be &self.buf.
|
Could you add a simple test? Looks good otherwise! |
|
Sorry, I was away at a conference and let this drop off my radar.
You can use |
Of course, I meant |
|
Is this ready for merging at this point? |
shepmaster
reviewed
Oct 31, 2018
src/libstd/io/buffered.rs
Outdated
| /// use std::io::BufWriter; | ||
| /// use std::net::TcpStream; | ||
| /// | ||
| /// let mut buf_writer = BufWriter::new(TcpStream::connect("127.0.0.1:34254").unwrap()); |
There was a problem hiding this comment.
This mut is unneeded for this example, right?
There was a problem hiding this comment.
I think most other examples return a result to avoid the unwrap:
fn main() -> std::io::Result<()> {
let buf_writer = BufWriter::new(TcpStream::connect("127.0.0.1:34254")?);Check to see what the prevailing pattern is and follow that, please.
src/libstd/io/buffered.rs
Outdated
| let b: &[_] = &[5, 6, 7]; | ||
| assert_eq!(buf, b); | ||
| assert_eq!(buf, [5, 6, 7]); | ||
| assert_eq!(*reader.buffer(), []); |
There was a problem hiding this comment.
These * don't seem to be needed — why did you have to add them?
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Looks OK to me — care to hit it with a rebase and force-push and we'll be on our way! |
fintelia
force-pushed
the
bufwriter-buffer
branch
from
72fbba0
to
59a0309
Compare
|
Ping from triage @shepmaster: it looks like the PR has been rebased and is ready for a final review. |
|
@bors r+ rollup |
|
📌 Commit 59a0309 has been approved by |
bors
added
S-waiting-on-bors
|
Argh; I forget GH doesn't ping for force pushes — sorry! |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 14, 2018
…ster Add BufWriter::buffer method CC rust-lang#45323
bors
added a commit
that referenced
this pull request
Nov 15, 2018
Rollup of 16 pull requests Successful merges: - #54906 (Reattach all grandchildren when constructing specialization graph.) - #55182 (Redox: Update to new changes) - #55211 (Add BufWriter::buffer method) - #55507 (Add link to std::mem::size_of to size_of intrinsic documentation) - #55530 (Speed up String::from_utf16) - #55556 (Use `Mmap` to open the rmeta file.) - #55622 (NetBSD: link libstd with librt in addition to libpthread) - #55827 (A few tweaks to iterations/collecting) - #55901 (fix various typos in doc comments) - #55926 (Change sidebar selector to fix compatibility with docs.rs) - #55930 (A handful of hir tweaks) - #55932 (core/char: Speed up `to_digit()` for `radix <= 10`) - #55935 (appveyor: Use VS2017 for all our images) - #55936 (save-analysis: be even more aggressive about ignorning macro-generated defs) - #55948 (submodules: update clippy from d8b4269 to 7e0ddef) - #55956 (add tests for some fixed ICEs)
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Nov 15, 2018
…ster Add BufWriter::buffer method CC rust-lang#45323
bors
added a commit
that referenced
this pull request
Nov 15, 2018
Rollup of 17 pull requests Successful merges: - #55182 (Redox: Update to new changes) - #55211 (Add BufWriter::buffer method) - #55507 (Add link to std::mem::size_of to size_of intrinsic documentation) - #55530 (Speed up String::from_utf16) - #55556 (Use `Mmap` to open the rmeta file.) - #55622 (NetBSD: link libstd with librt in addition to libpthread) - #55750 (Make `NodeId` and `HirLocalId` `newtype_index`) - #55778 (Wrap some query results in `Lrc`.) - #55781 (More precise spans for temps and their drops) - #55785 (Add mem::forget_unsized() for forgetting unsized values) - #55852 (Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint) - #55865 (Unix RwLock: avoid racy access to write_locked) - #55901 (fix various typos in doc comments) - #55926 (Change sidebar selector to fix compatibility with docs.rs) - #55930 (A handful of hir tweaks) - #55932 (core/char: Speed up `to_digit()` for `radix <= 10`) - #55956 (add tests for some fixed ICEs) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC #45323