Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the stdsimd submodule #56926

Merged
merged 1 commit into from
Dec 25, 2018
Merged

Conversation

alexcrichton
Copy link
Member

This brings in a few updates:

  • Update wasm intrinsic naming for atomics
  • Update and reimplement most simd128 wasm intrinsics
  • Other misc improvements here and there, including a small start to
    AVX-512 intrinsics

@rust-highfive
Copy link
Collaborator

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2018
@TimNN
Copy link
Contributor

TimNN commented Dec 17, 2018

R=me if travis is green

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

This brings in a few updates:

* Update wasm intrinsic naming for atomics
* Update and reimplement most simd128 wasm intrinsics
* Other misc improvements here and there, including a small start to
  AVX-512 intrinsics
@alexcrichton
Copy link
Member Author

@bors: r=TimNN

@bors
Copy link
Contributor

bors commented Dec 17, 2018

📌 Commit 7d2c6509258c6d8280eb0bf6bd9d27717f560d0f has been approved by TimNN

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2018
@alexcrichton
Copy link
Member Author

@bors: rollup

@pietroalbini
Copy link
Member

@bors r-

Failed in the rollup:

[00:03:04] error[E0441]: unrecognized platform-specific intrinsic function: `simd_select_bitmask`
[00:03:04]   --> src/libcore/../stdsimd/coresimd/simd_llvm.rs:52:5
[00:03:04]    |
[00:03:04] 52 |     pub fn simd_select_bitmask<M, T>(m: M, a: T, b: T) -> T;
[00:03:04] 
[00:03:04] error: aborting due to previous error

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2018
@alexcrichton
Copy link
Member Author

@bors: rollup- r=TimNN

Did some investigation locally and looks like the rollup may have gotten mixed up and forgot the last commit of stdsimd, which is needed to fix that failure (and is oddly enough present in this PR...)

@bors
Copy link
Contributor

bors commented Dec 20, 2018

📌 Commit 7d2c6509258c6d8280eb0bf6bd9d27717f560d0f has been approved by TimNN

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 20, 2018
@pietroalbini
Copy link
Member

@bors retry

Trying to wake bors up.

@pietroalbini
Copy link
Member

@bors are you still there?

@bors
Copy link
Contributor

bors commented Dec 24, 2018

🍰 Activated

@pietroalbini
Copy link
Member

@bors r=TimNN

@bors
Copy link
Contributor

bors commented Dec 24, 2018

📌 Commit 5e5823c has been approved by TimNN

@bors
Copy link
Contributor

bors commented Dec 25, 2018

⌛ Testing commit 5e5823c with merge e57ab26...

bors added a commit that referenced this pull request Dec 25, 2018
Update the stdsimd submodule

This brings in a few updates:

* Update wasm intrinsic naming for atomics
* Update and reimplement most simd128 wasm intrinsics
* Other misc improvements here and there, including a small start to
  AVX-512 intrinsics
@bors
Copy link
Contributor

bors commented Dec 25, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: TimNN
Pushing e57ab26 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants