actually take a slice in this example #57450

steveklabnik · 2019-01-08T19:59:29Z

rust-highfive · 2019-01-08T19:59:33Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-01-08T21:43:06Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:002d769b:start=1546977835050774444,finish=1546977836096022281,duration=1045247837
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:16:57] 
[01:16:57] running 118 tests
[01:17:23] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:17:27] ......iii.i.....ii
[01:17:27] 
[01:17:27]  finished in 29.667
[01:17:27] travis_fold:end:test_debuginfo

---
[01:37:59] .................................................................................................... 400/991
[01:38:08] ..........................i.i.....................................iiii........ii.................... 500/991
[01:38:15] .................................................................................................... 600/991
[01:38:22] .................................................................................................... 700/991
[01:38:31] .............iiii............F...................................................................... 800/991
 0:33:50
 0:33:50
[01:38:50] make: *** [check] Error 1
[01:38:50] Makefile:48: recipe for target 'check' failed
136260 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps
124960 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu
124956 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release
122052 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps
---
travis_time:end:134f4c18:start=1546983781478755336,finish=1546983781483668675,duration=4913339
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:03477243
$ ln -s . checkout && for CORE in obj/cores/core.*; do Etravis_time:end:1a7569f0:start=1546983781558276453,finish=1546983781569075282,duration=10798829

Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/libstd/primitive_docs.rs

rust-highfive · 2019-01-09T02:18:14Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:39612e90:start=1546994803717246026,finish=1546994879909973627,duration=76192727601
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:09:05] 
[01:09:05] running 118 tests
[01:09:29] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:09:34] ......iii.i.....ii
[01:09:34] 
[01:09:34]  finished in 28.539
[01:09:34] travis_fold:end:test_debuginfo

---
[01:29:08] .................................................................................................... 400/991
[01:29:16] ..........................i.i.....................................iiii........ii.................... 500/991
[01:29:23] .................................................................................................... 600/991
[01:29:30] .................................................................................................... 700/991
[01:29:38] .............iiii............F...................................................................... 800/991
[01:29:56] .......................................iiii................................................
[01:29:56] failures:
[01:29:56] 
[01:29:56] ---- primitive_docs.rs - prim_slice (line 573) stdout ----
[01:29:56] ---- primitive_docs.rs - prim_slice (line 573) stdout ----
[01:29:56] error[E0596]: cannot borrow immutable local variable `x` as mutable
[01:29:56]   |
[01:29:56]   |
[01:29:56] 4 | let x = [1, 2, 3];
[01:29:56]   |     - help: make this binding mutable: `mut x`
[01:29:56] 5 | let x = &mut x[..]; // take a full slice of `x`
[01:29:56]   |              ^ cannot borrow mutably
[01:29:56] thread 'primitive_docs.rs - prim_slice (line 573)' panicked at 'couldn't compile the test', src/librustdoc/test.rs:321:13
[01:29:56] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:29:56] 
[01:29:56] 
---
[01:29:56] 
[01:29:56] error: test failed, to rerun pass '--doc'
[01:29:56] 
[01:29:56] 
[01:29:56] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "std" "--" "--quiet"
[01:29:56] 
[01:29:56] 
[01:29:56] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:29:56] Build completed unsuccessfully in 0:32:05
[01:29:56] Build completed unsuccessfully in 0:32:05
[01:29:56] make: *** [check] Error 1
[01:29:56] Makefile:48: recipe for target 'check' failed
3092524 ./obj
3077260 ./obj/build
2417924 ./obj/build/x86_64-unknown-linux-gnu
1135364 ./src
---
175216 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc
160416 ./obj/build/bootstrap/debug/incremental
153276 ./src/tools/clang
144308 ./obj/build/bootstrap/debug/incremental/bootstrap-2zp0dzg596kc2
144304 ./obj/build/bootstrap/debug/incremental/bootstrap-2zp0dzg596kc2/s-f8d3oyo3n2-11vkl9s-2vbxibotdym97
138624 ./obj/build/x86_64-unknown-linux-gnu/stage0-rus_64-unknown-linux-gnu
61668 ./obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release
61364 ./obj/build/x86_64-unknown-linux-gnu/stage1-std
61036 ./obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps
---
32632 ./obj/build/x86_64-unknown-linux-gnu/doc/src
32040 ./src/llvm/test/Transforms
30696 ./obj/build/x86_64-unknown-linux-gnu/stage1-std/release/build
28344 ./obj/build/x86_64-unknown-linux-gnu/doc/book
27052 ./obj/build/x86_64-unknown-linux-gnu/stackout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/libstd/primitive_docs.rs

Fixes rust-lang#45678

KodrAus · 2019-01-09T22:51:49Z

Thanks @steveklabnik!

@bors r+ rollup

bors · 2019-01-09T22:51:50Z

📌 Commit 4a454d6 has been approved by KodrAus

bors · 2019-01-10T06:15:02Z

⌛ Testing commit 4a454d6 with merge 594c1ea099feb4d0f506c4dde04c7c2d78144156...

bors · 2019-01-10T06:15:12Z

💔 Test failed - status-appveyor

pietroalbini · 2019-01-10T08:21:51Z

@bors retry
AppVeyor... what's wrong with you today?

actually take a slice in this example Fixes rust-lang#45678

@ghost

Rollup of 26 pull requests Successful merges: - #56425 (Redo the docs for Vec::set_len) - #56906 (Issue #56905) - #57042 (Don't call `FieldPlacement::count` when count is too large) - #57175 (Stabilize `let` bindings and destructuring in constants and const fn) - #57192 (Change std::error::Error trait documentation to talk about `source` instead of `cause`) - #57296 (Fixed the link to the ? operator) - #57368 (Use CMAKE_{C,CXX}_COMPILER_LAUNCHER for ccache) - #57400 (Rustdoc: update Source Serif Pro and replace Heuristica italic) - #57417 (rustdoc: use text-based doctest parsing if a macro is wrapping main) - #57433 (Add link destination for `read-ownership`) - #57434 (Remove `CrateNum::Invalid`.) - #57441 (Supporting backtrace for x86_64-fortanix-unknown-sgx.) - #57450 (actually take a slice in this example) - #57459 (Reference tracking issue for inherent associated types in diagnostic) - #57463 (docs: Fix some 'second-edition' links) - #57466 (Remove outdated comment) - #57493 (use structured suggestion when casting a reference) - #57498 (make note of one more normalization that Paths do) - #57499 (note that FromStr does not work for borrowed types) - #57505 (Remove submodule step from README) - #57510 (Add a profiles section to the manifest) - #57511 (Fix undefined behavior) - #57519 (Correct RELEASES.md for 1.32.0) - #57522 (don't unwrap unexpected tokens in `format!`) - #57530 (Fixing a typographical error.) - #57535 (Stabilise irrefutable if-let and while-let patterns) Failed merges: r? @ghost

rust-highfive assigned KodrAus Jan 8, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2019

varkor reviewed Jan 9, 2019

View reviewed changes

src/libstd/primitive_docs.rs Outdated Show resolved Hide resolved

Centril reviewed Jan 9, 2019

View reviewed changes

src/libstd/primitive_docs.rs Outdated Show resolved Hide resolved

actually take a slice in this example

4a454d6

Fixes rust-lang#45678

steveklabnik force-pushed the gh45678 branch from 5770942 to 4a454d6 Compare January 9, 2019 19:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2019

Centril mentioned this pull request Jan 10, 2019

Rollup of 19 pull requests #57503

Closed

Centril added a commit to Centril/rust that referenced this pull request Jan 12, 2019

Rollup merge of rust-lang#57450 - steveklabnik:gh45678, r=KodrAus

0b1427e

actually take a slice in this example Fixes rust-lang#45678

Centril mentioned this pull request Jan 12, 2019

Rollup of 26 pull requests #57542

Merged

bors merged commit 4a454d6 into rust-lang:master Jan 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

actually take a slice in this example #57450

actually take a slice in this example #57450

steveklabnik commented Jan 8, 2019

rust-highfive commented Jan 8, 2019

rust-highfive commented Jan 8, 2019

rust-highfive commented Jan 9, 2019

KodrAus commented Jan 9, 2019

bors commented Jan 9, 2019

bors commented Jan 10, 2019

bors commented Jan 10, 2019

pietroalbini commented Jan 10, 2019

actually take a slice in this example #57450

actually take a slice in this example #57450

Conversation

steveklabnik commented Jan 8, 2019

rust-highfive commented Jan 8, 2019

rust-highfive commented Jan 8, 2019

rust-highfive commented Jan 9, 2019

KodrAus commented Jan 9, 2019

bors commented Jan 9, 2019

bors commented Jan 10, 2019

bors commented Jan 10, 2019

pietroalbini commented Jan 10, 2019