Rollup of 4 pull requests #57982
Closed
Rollup of 4 pull requests #57982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions return a reference to a new object and do not modify in-place
as the following code shows:
````
let s = String::from(" hello ");
s.trim();
assert_eq!(s, " hello ");
````
The new reference should be bound to a variable as now indicated by #[must_use].
trimmed string is returned as a slice instead of a new allocation Co-Authored-By: matthiaskrgr <matthias.krueger@famsik.de>
mark str::string::String.trim.* functions as #[must_use].
The functions return a reference to a new object and do not modify in-place
as the following code shows:
````
let s = String::from(" hello ");
s.trim();
assert_eq!(s, " hello ");
````
The new reference should be bound to a variable as now indicated by #[must_use].
…mulacrum use `SOURCE_DATE_EPOCH` for man page time if set Fixes rust-lang#57776.
…alexcrichton Introduce into_raw_non_null on Rc and Arc None
…ichton override `VecDeque`'s `Iter::try_fold` This should improve performance (wherever it is used), but I haven't found the time to benchmark it yet.
|
@bors r+ p=4 |
|
📌 Commit 47e0812 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 47e0812 with merge d2db4ead0ff13941d359a071da3f6895476d72f3... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
SOURCE_DATE_EPOCHfor man page time if set #57920 (useSOURCE_DATE_EPOCHfor man page time if set)VecDeque'sIter::try_fold#57974 (overrideVecDeque'sIter::try_fold)Failed merges:
r? @ghost