Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain error when yielding a reference to a local variable #60176

Merged
merged 1 commit into from
May 14, 2019
Merged

Explain error when yielding a reference to a local variable #60176

merged 1 commit into from
May 14, 2019

Conversation

matthewjasper
Copy link
Contributor

Closes #56508

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2019
@matthewjasper
Copy link
Contributor Author

r? @pnkfelix

@rust-highfive rust-highfive assigned pnkfelix and unassigned oli-obk Apr 22, 2019
@pnkfelix
Copy link
Member

awesome!

@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 13, 2019

📌 Commit d9ea132 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2019
@bors
Copy link
Contributor

bors commented May 13, 2019

⌛ Testing commit d9ea132 with merge 44c5b27852b35ef0f532587d7259a52248aa882b...

@pietroalbini
Copy link
Member

@bors retry

Yielding priority to the security vulnerability fix on stable.

Centril added a commit to Centril/rust that referenced this pull request May 13, 2019
@Centril
Rollup merge of rust-lang#60176 - matthewjasper:yield-ref-to-local, r…
2821329 
…=pnkfelix

Explain error when yielding a reference to a local variable

Closes rust-lang#56508
@Centril Centril mentioned this pull request May 13, 2019
Merged
bors added a commit that referenced this pull request May 14, 2019
@bors
Auto merge of #60794 - Centril:rollup-vlguvns, r=Centril
80e7cde 
Rollup of 5 pull requests

Successful merges:

 - #60176 (Explain error when yielding a reference to a local variable)
 - #60201 (coretest: Downgrade deny to warn)
 - #60562 (Add #[doc(hidden)] attribute on compiler generated module.)
 - #60710 (Use `delay_span_bug` for error cases when checking `AnonConst` parent)
 - #60770 (add impl_trait_in_bindings to INCOMPLETE_FEATURES)

Failed merges:

r? @ghost
@bors bors merged commit d9ea132 into rust-lang:master May 14, 2019
@matthewjasper matthewjasper deleted the yield-ref-to-local branch July 29, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NLL diagnostic regression on generator + short-lived yield
6 participants
@matthewjasper @rust-highfive @pnkfelix @bors @pietroalbini @oli-obk