Failure is not an option #62113

Centril · 2019-06-25T09:24:32Z

Remove the src/test/compile-fail folder and move all of its tests into appropriate places in src/test/ui. Some tests in src/test/ui are also moved as a result for better categorization.

r? @petrochenkov

petrochenkov · 2019-06-25T09:41:14Z

Are you sure you know what you just got into?
All the tests in compile-fail are not migrated to ui because they either produce unstable diagnostics changing from run to run, or heavily platform-dependent diagnostics.
Both kinds of tests require either compiler changes (HashMap -> BTreeMap or something) or some compiletest extensions, or perhaps splitting into multiple per-platform tests to migrate.
If you want to implement all that pre-requisite stuff, that would be really great.

(It's possible that some tests are there by accident though.)

Centril · 2019-06-25T09:59:59Z

Are you sure you know what you just got into?
All the tests in compile-fail are not migrated to ui because they either produce unstable diagnostics changing from run to run, or heavily platform-dependent diagnostics.

Well... now I do... 😂 I just thought they were in compile-fail because no one had bothered to move them.

(It's possible that some tests are there by accident though.)

Hmm... so maybe let's move them more incrementally and see which parts stick?
It's hard to tell what exactly is unstable or heavily platform-dependent otherwise.

petrochenkov · 2019-06-25T10:07:37Z

It's hard to tell what exactly is unstable or heavily platform-dependent otherwise.

Yeah, it would be nice to try and see what CI says.
Things could change from the last time the migration was attempted, diagnostics could be fixed and become stable, etc.

petrochenkov · 2019-06-25T10:10:36Z

cc @davidtwco
Did you try to do anything with those tests (splitting, normalization), or left everything that didn't pass on CI?
I remember the compile-fail -> ui migration PR was huge and it wasn't the best time to care about details.

davidtwco · 2019-06-25T10:33:57Z

I never did revisit these tests and attempt anything to get them working on the ui suite. The only remaining tests in compile-fail were ones that were problematic for some reason or another when moved to ui. I opened #53353 at the time, which has a little more information, but unfortunately not much.

rust-highfive · 2019-06-25T10:59:20Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1f7aa6b0:start=1561456865130605559,finish=1561456866652339815,duration=1521734256
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_ui
Check compiletest suite=ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:54:19] 
[00:54:19] running 5723 tests
[00:54:24] .............................F...................................................................... 100/5723
[00:54:34] .................................................................................................... 300/5723
[00:54:37] .................................................................................................... 400/5723
[00:54:37] .................................................................................................... 400/5723
[00:54:40] .................................................................................................F.. 500/5723
[00:54:47] .................................................................................................... 700/5723
[00:54:51] .................................................................................................... 800/5723
[00:54:56] .................................................................................................... 900/5723
[00:54:56] .................................................................................................... 900/5723
[00:55:01] ..............................................................i.....F.....i......................... 1000/5723
[00:55:04] ...........................................................................................iiiii.... 1100/5723
[00:55:10] .................................................................................................... 1300/5723
[00:55:13] .................................................................................................... 1400/5723
[00:55:16] .................................................................................................... 1500/5723
[00:55:19] .................................................................................................... 1600/5723
---
[00:56:06] .................................................................................................... 2900/5723
[00:56:09] .................................................................................................... 3000/5723
[00:56:14] .................................................................................................... 3100/5723
[00:56:17] .................................................................................................... 3200/5723
[00:56:20] ..................................................F................................................. 3300/5723
[00:56:28] ......................i............................................................................. 3500/5723
[00:56:32] .................................................................................................ii. 3600/5723
[00:56:35] ..i..ii............................................................................................. 3700/5723
[00:56:39] .................................................................................................... 3800/5723
---
[00:57:57] failures:
[00:57:57] 
[00:57:57] ---- [ui] ui/asm/asm-src-loc-codegen-units.rs stdout ----
[00:57:57] normalized stderr:
[00:57:57] error: <inline asm>:1:2: error: invalid instruction mnemonic 'nowayisthisavalidinstruction'
[00:57:57]         nowayisthisavalidinstruction
[00:57:57] 
[00:57:57]   --> $DIR/asm-src-loc-codegen-units.rs:10:9
[00:57:57]    |
[00:57:57]    |
[00:57:57] LL |         asm!("nowayisthisavalidinstruction");
[00:57:57] 
[00:57:57] error: aborting due to previous error
[00:57:57] 
[00:57:57] 
[00:57:57] 
[00:57:57] 
[00:57:57] 
[00:57:57] The actual stderr differed from the expected stderr.
[00:57:57] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/asm-src-loc-codegen-units/asm-src-loc-codegen-units.stderr
[00:57:57] To update references, rerun the tests and pass the `--bless` flag
[00:57:57] To only update this specific test, also pass `--test-args asm/asm-src-loc-codegen-units.rs`
[00:57:57] error: 1 errors occurred comparing output.
[00:57:57] status: exit code: 1
[00:57:57] status: exit code: 1
[00:57:57] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/asm/asm-src-loc-codegen-units.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/asm-src-loc-codegen-units" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-C" "codegen-units=2" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/asm-src-loc-codegen-units/auxiliary" "-A" "unused"
[00:57:57] ------------------------------------------
[00:57:57] 
[00:57:57] ------------------------------------------
[00:57:57] stderr:
[00:57:57] stderr:
[00:57:57] ------------------------------------------
[00:57:57] error: <inline asm>:1:2: error: invalid instruction mnemonic 'nowayisthisavalidinstruction'
[00:57:57]         nowayisthisavalidinstruction
[00:57:57] 
[00:57:57]   --> /checkout/src/test/ui/asm/asm-src-loc-codegen-units.rs:10:9
[00:57:57]    |
[00:57:57]    |
[00:57:57] LL |         asm!("nowayisthisavalidinstruction"); //~ ERROR instruction
[00:57:57] 
[00:57:57] error: aborting due to previous error
[00:57:57] 
[00:57:57] 
[00:57:57] 
[00:57:57] ------------------------------------------
[00:57:57] 
[00:57:57] 
[00:57:57] ---- [ui] ui/chalkify/recursive_where_clause_on_type.rs stdout ----
[00:57:57] diff of stderr:
[00:57:57] 
[00:57:57] 1 error: the type `S` is not well-formed (chalk)
[00:57:57] +   --> $DIR/recursive_where_clause_on_type.rs:26:11
[00:57:57] 3    |
[00:57:57] 3    |
[00:57:57] 4 LL |     foo::<S>()
[00:57:57] +    |           ^
[00:57:57] 6 
[00:57:57] 6 
[00:57:57] 7 error: the type `S` is not well-formed (chalk)
[00:57:57] +   --> $DIR/recursive_where_clause_on_type.rs:26:5
[00:57:57] 9    |
[00:57:57] 9    |
[00:57:57] 10 LL |     foo::<S>()
[00:57:57] +    |     ^^^^^^^^
[00:57:57] 12 
[00:57:57] 13 error: aborting due to 2 previous errors
[00:57:57] 14 
[00:57:57] 14 
[00:57:57] 
[00:57:57] 
[00:57:57] The actual stderr differed from the expected stderr.
[00:57:57] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/chalkify/recursive_where_clause_on_type/recursive_where_clause_on_type.stderr
[00:57:57] To update references, rerun the tests and pass the `--bless` flag
[00:57:57] To only update this specific test, also pass `--test-args chalkify/recursive_where_clause_on_type.rs`
[00:57:57] error: 1 errors occurred comparing output.
[00:57:57] status: exit code: 1
[00:57:57] status: exit code: 1
[00:57:57] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/chalkify/recursive_where_clause_on_type.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/chalkify/recursive_where_clause_on_type" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "chalk" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/chalkify/recursive_where_clause_on_type/auxiliary" "-A" "unused"
[00:57:57] ------------------------------------------
[00:57:57] 
[00:57:57] ------------------------------------------
[00:57:57] stderr:
[00:57:57] stderr:
[00:57:57] ------------------------------------------
[00:57:57] error: the type `S` is not well-formed (chalk)
[00:57:57]    |
[00:57:57]    |
[00:57:57] LL |     foo::<S>() //~ ERROR the type `S` is not well-formed (chalk)
[00:57:57] 
[00:57:57] 
[00:57:57] error: the type `S` is not well-formed (chalk)
[00:57:57]    |
[00:57:57]    |
[00:57:57] LL |     foo::<S>() //~ ERROR the type `S` is not well-formed (chalk)
[00:57:57] 
[00:57:57] error: aborting due to 2 previous errors
[00:57:57] 
[00:57:57] 
---
[00:57:57] 
[00:57:57] 5    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:57:57] 6    |
[00:57:57] 7    = note: candidates:
[00:57:57] -            crate `crateresolve1`: $TEST_BUILD_DIR/crateresolve1/crateresolve1/auxiliary/libcrateresolve1-3.so
[00:57:57] -            crate `crateresolve1`: $TEST_BUILD_DIR/crateresolve1/crateresolve1/auxiliary/libcrateresolve1-1.so
[00:57:57] 10            crate `crateresolve1`: $TEST_BUILD_DIR/crateresolve1/crateresolve1/auxiliary/libcrateresolve1-2.so
[00:57:57] +            crate `crateresolve1`: $TEST_BUILD_DIR/crateresolve1/crateresolve1/auxiliary/libcrateresolve1-1.so
[00:57:57] +            crate `crateresolve1`: $TEST_BUILD_DIR/crateresolve1/crateresolve1/auxiliary/libcrateresolve1-3.so
[00:57:57] 12 error[E0463]: can't find crate for `crateresolve1`
[00:57:57] 13   --> $DIR/crateresolve1.rs:6:1
[00:57:57] 
[00:57:57] 
[00:57:57] 
[00:57:57] The actual stderr differed from the expected stderr.
[00:57:57] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/crateresolve1/crateresolve1/crateresolve1.stderr
[00:57:57] To update references, rerun the tests and pass the `--bless` flag
[00:57:57] To only update this specific test, also pass `--test-args crateresolve1/crateresolve1.rs`
[00:57:57] error: 1 errors occurred comparing output.
[00:57:57] status: exit code: 1
[00:57:57] status: exit code: 1
[00:57:57] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/crateresolve1/crateresolve1.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/crateresolve1/crateresolve1" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/crateresolve1/crateresolve1/auxiliary" "-A" "unused"
[00:57:57] ------------------------------------------
[00:57:57] 
[00:57:57] ------------------------------------------
[00:57:57] stderr:
---
[00:57:57] LL | extern crate crateresolve1;
[00:57:57]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:57:57]    |
[00:57:57]    = note: candidates:
[00:57:57]            crate `crateresolve1`: /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/crateresolve1/crateresolve1/auxiliary/libcrateresolve1-2.so
[00:57:57]            crate `crateresolve1`: /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/crateresolve1/crateresolve1/auxiliary/libcrateresolve1-1.so
[00:57:57]            crate `crateresolve1`: /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/crateresolve1/crateresolve1/auxiliary/libcrateresolve1-3.so
[00:57:57] error[E0463]: can't find crate for `crateresolve1`
[00:57:57]   --> /checkout/src/test/ui/crateresolve1/crateresolve1.rs:6:1
[00:57:57]    |
[00:57:57] LL | extern crate crateresolve1;
---
[00:57:57] diff of stderr:
[00:57:57] 
[00:57:57] 1 error: linking with `ld` failed: exit code: 1
[00:57:57] 2    |
[00:57:57] -    = note: "ld" "-L" "$BUILD_DIR/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib" "$TEST_BUILD_DIR/linkage/invalid-link-args/invalid-link-args.invalid_link_args.7rcbfp3g-cgu.0.rcgu.o" "$TEST_BUILD_DIR/linkage/invalid-link-args/invalid-link-args.invalid_link_args.7rcbfp3g-cgu.1.rcgu.o" "-o" "$TEST_BUILD_DIR/linkage/invalid-link-args/invalid-link-args" "--gc-sections" "-pie" "-zrelro" "-znow" "-O1" "-L" "$BUILD_DIR/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "$TEST_BUILD_DIR/linkage/invalid-link-args/auxiliary" "-L" "$BUILD_DIR/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--start-group" "-L" "$BUILD_DIR/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lstd-df58114e777eef4d" "--end-group" "-Bstatic" "$BUILD_DIR/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-34e2d1be8ef7ab6e.rlib" "-Bdynamic" "-ldl" "-lrt" "-lpthread" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread" "-lutil" "-lutil" "-Wl,-rpath,$ORIGIN/../../../../stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-rpath,$LIB_DIR/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,--enable-new-dtags" "aFdEfSeVEEE"
[00:57:57] -    = note: ld: unrecognised option '-Wl,-rpath,$ORIGIN/../../../../stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib'
[00:57:57] +    = note: "ld" "-L" "$BUILD_DIR/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "$TEST_BUILD_DIR/linkage/invalid-link-args/invalid-link-args.invalid_link_args.7rcbfp3g-cgu.0.rcgu.o" "$TEST_BUILD_DIR/linkage/invalid-link-args/invalid-link-args.invalid_link_args.7rcbfp3g-cgu.1.rcgu.o" "-o" "$TEST_BUILD_DIR/linkage/invalid-link-args/invalid-link-args" "--gc-sections" "-pie" "-zrelro" "-znow" "-O1" "-L" "$BUILD_DIR/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "$TEST_BUILD_DIR/linkage/invalid-link-args/auxiliary" "-L" "$BUILD_DIR/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--start-group" "-L" "$BUILD_DIR/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lstd-2e753a4979f4d43c" "--end-group" "-Bstatic" "$BUILD_DIR/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-84bb07d1eb68f25a.rlib" "-Bdynamic" "-ldl" "-lrt" "-lpthread" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread" "-lutil" "-lutil" "-Wl,-rpath,$ORIGIN/../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-rpath,$LIB_DIR/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,--enable-new-dtags" "aFdEfSeVEEE"
[00:57:57] +    = note: ld: unrecognized option '-Wl,-rpath,$ORIGIN/../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib'
[00:57:57] 5            ld: use the --help option for usage information
[00:57:57] 7 
[00:57:57] 
[00:57:57] 
[00:57:57] The actual stderr differed from the expected stderr.
[00:57:57] The actual stderr differed from the expected stderr.
[00:57:57] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/linkage/invalid-link-args/invalid-link-args.stderr
[00:57:57] To update references, rerun the tests and pass the `--bless` flag
[00:57:57] To only update this specific test, also pass `--test-args linkage/invalid-link-args.rs`
[00:57:57] error: 1 errors occurred comparing output.
[00:57:57] status: exit code: 1
[00:57:57] status: exit code: 1
[00:57:57] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/linkage/invalid-link-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/linkage/invalid-link-args" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-C" "linker-flavor=ld" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/linkage/invalid-link-args/auxiliary" "-A" "unused"
[00:57:57] ------------------------------------------
[00:57:57] 
[00:57:57] ------------------------------------------
[00:57:57] stderr:
[00:57:57] stderr:
[00:57:57] ------------------------------------------
[00:57:57] error: linking with `ld` failed: exit code: 1
[00:57:57]    |
[00:57:57]    = note: "ld" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/linkage/invalid-link-args/invalid-link-args.invalid_link_args.7rcbfp3g-cgu.0.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/linkage/invalid-link-args/invalid-link-args.invalid_link_args.7rcbfp3g-cgu.1.rcgu.o" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/linkage/invalid-link-args/invalid-link-args" "--gc-sections" "-pie" "-zrelro" "-znow" "-O1" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/linkage/invalid-link-args/auxiliary" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--start-group" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lstd-2e753a4979f4d43c" "--end-group" "-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-84bb07d1eb68f25a.rlib" "-Bdynamic" "-ldl" "-lrt" "-lpthread" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread" "-lutil" "-lutil" "-Wl,-rpath,$ORIGIN/../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-rpath,/checkout/obj/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,--enable-new-dtags" "aFdEfSeVEEE"
[00:57:57]    = note: ld: unrecognized option '-Wl,-rpath,$ORIGIN/../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib'
[00:57:57]            ld: use the --help option for usage information
[00:57:57] 
[00:57:57] error: aborting due to previous error
[00:57:57] 
[00:57:57] 
---
[00:57:57] 
[00:57:57] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[00:57:57] 
[00:57:57] 
[00:57:57] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:57:57] 
[00:57:57] 
[00:57:57] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:57:57] Build completed unsuccessfully in 0:53:20
---
travis_time:end:1e35442f:start=1561460355508993106,finish=1561460355513955900,duration=4962794
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00decb04
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ];

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

mark-i-m · 2019-06-25T15:30:31Z

Failure is not an option

I think usually it is a Result, no?

I opened #53353 at the time, which has a little more information, but unfortunately not much.

Did the errors have anything in common? e.g. were they all from a particular part of the compiler? Is there something we can focus on to get the most bang for the buck?

Centril · 2019-06-25T15:33:50Z

I think usually it is a Result, no?

I hear it can also be an Outcome!

Is there something we can focus on to get the most bang for the buck?

I'll save this branch into another for now and remove some bits from the PR and see if we can merge that. Once we have determined the set of tests that cannot be moved we can consider fixes for those.

davidtwco · 2019-06-25T15:36:10Z

Did the errors have anything in common? e.g. were they all from a particular part of the compiler? Is there something we can focus on to get the most bang for the buck?

Unfortunately, I can’t remember. I’m afraid I didn’t keep notes as to what the failures were at the time, but you could probably look at old Travis logs from the original PR, if they are still around.

Centril · 2019-06-27T12:21:52Z

Extracted a subset of this PR into #62177.

Marking as blocking progress on that.

@petrochenkov

…s, r=petrochenkov Move some tests in src/test/compile-fail -> src/test/ui This is a subset of rust-lang#62113. Hopefully everything here sticks, but if it doesn't I'll remove tests until it does. r? @petrochenkov

bors · 2019-07-04T03:16:29Z

☔ The latest upstream changes (presumably #62355) made this pull request unmergeable. Please resolve the merge conflicts.

petrochenkov · 2019-09-11T09:30:03Z

#62177 was closed, so closing this as well.

rust-highfive assigned petrochenkov Jun 25, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2019

This comment has been minimized.

Sign in to view

Centril added 2 commits June 25, 2019 11:57

Move tests in src/test/compile-fail -> src/test/ui.

9723ed0

bye bye src/test/compile-fail.

3282050

Centril force-pushed the compile-fail-no-more branch from c260d4f to 3282050 Compare June 25, 2019 09:58

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2019

Centril mentioned this pull request Jun 27, 2019

Move some tests in src/test/compile-fail -> src/test/ui #62177

Closed

Centril added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2019

petrochenkov closed this Sep 11, 2019

petrochenkov added S-blocked-closed and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Sep 11, 2019

jyn514 added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked-closed labels Mar 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Failure is not an option #62113

Failure is not an option #62113

Centril commented Jun 25, 2019 •

edited

Loading

petrochenkov commented Jun 25, 2019 •

edited

Loading

This comment has been minimized.

Centril commented Jun 25, 2019

petrochenkov commented Jun 25, 2019

petrochenkov commented Jun 25, 2019

davidtwco commented Jun 25, 2019

rust-highfive commented Jun 25, 2019

mark-i-m commented Jun 25, 2019

Centril commented Jun 25, 2019 •

edited

Loading

davidtwco commented Jun 25, 2019 •

edited

Loading

Centril commented Jun 27, 2019

bors commented Jul 4, 2019

petrochenkov commented Sep 11, 2019

Failure is not an option #62113

Failure is not an option #62113

Conversation

Centril commented Jun 25, 2019 • edited Loading

petrochenkov commented Jun 25, 2019 • edited Loading

This comment has been minimized.

Centril commented Jun 25, 2019

petrochenkov commented Jun 25, 2019

petrochenkov commented Jun 25, 2019

davidtwco commented Jun 25, 2019

rust-highfive commented Jun 25, 2019

mark-i-m commented Jun 25, 2019

Centril commented Jun 25, 2019 • edited Loading

davidtwco commented Jun 25, 2019 • edited Loading

Centril commented Jun 27, 2019

bors commented Jul 4, 2019

petrochenkov commented Sep 11, 2019

Centril commented Jun 25, 2019 •

edited

Loading

petrochenkov commented Jun 25, 2019 •

edited

Loading

Centril commented Jun 25, 2019 •

edited

Loading

davidtwco commented Jun 25, 2019 •

edited

Loading