Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize use of backticks in compiler messages for librustc_metadata #62812

Merged
merged 1 commit into from
Jul 22, 2019
Merged

normalize use of backticks in compiler messages for librustc_metadata #62812

merged 1 commit into from
Jul 22, 2019

Conversation

fakenine
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2019
@fakenine
Copy link
Contributor Author

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned eddyb Jul 19, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-07-19T19:26:21.7688197Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-19T19:26:21.7935837Z ##[command]git config gc.auto 0
2019-07-19T19:26:21.8006279Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-19T19:26:21.8056776Z ##[command]git config --get-all http.proxy
2019-07-19T19:26:21.8185808Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62812/merge:refs/remotes/pull/62812/merge
---
2019-07-19T19:26:55.5084032Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-19T19:26:55.5084077Z 
2019-07-19T19:26:55.5084256Z   git checkout -b <new-branch-name>
2019-07-19T19:26:55.5084282Z 
2019-07-19T19:26:55.5084332Z HEAD is now at 20bf1a144 Merge b11f1d3b11ac3dce87cfe09e90c10aad364f5627 into 527dce7137f7a3c7bf47d9a503abf25f88ea22de
2019-07-19T19:26:55.5225089Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-19T19:26:55.5227512Z ==============================================================================
2019-07-19T19:26:55.5227721Z Task         : Bash
2019-07-19T19:26:55.5227762Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-19T19:33:06.4162022Z tidy check
2019-07-19T19:33:07.3292375Z * 577 error codes
2019-07-19T19:33:07.3292580Z * highest error code: E0732
2019-07-19T19:33:07.6383303Z * 266 features
2019-07-19T19:33:08.1914231Z Stray file with UI testing output: "/checkout/src/test/ui/feature-gates/feature-gate-dropck-ugeh.stderr"
2019-07-19T19:33:08.2206669Z some tidy checks failed
2019-07-19T19:33:08.2212229Z 
2019-07-19T19:33:08.2212229Z 
2019-07-19T19:33:08.2212930Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-07-19T19:33:08.2213347Z 
2019-07-19T19:33:08.2213396Z 
2019-07-19T19:33:08.2227636Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-19T19:33:08.2227738Z Build completed unsuccessfully in 0:01:31
2019-07-19T19:33:08.2227738Z Build completed unsuccessfully in 0:01:31
2019-07-19T19:33:09.5356175Z ##[error]Bash exited with code '1'.
2019-07-19T19:33:09.5410564Z ##[section]Starting: Checkout
2019-07-19T19:33:09.5412121Z ==============================================================================
2019-07-19T19:33:09.5412172Z Task         : Get sources
2019-07-19T19:33:09.5412216Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@GuillaumeGomez
Copy link
Member

Thanks!

r=me once tests fixed

@fakenine fakenine force-pushed the normalize_use_of_backticks_compiler_messages_p11 branch from b11f1d3 to 19a848d Compare July 19, 2019 20:25
@fakenine
Copy link
Contributor Author

r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 20, 2019

📌 Commit 19a848d has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 21, 2019
@Centril
Rollup merge of rust-lang#62812 - fakenine:normalize_use_of_backticks…
a343f7d 
…_compiler_messages_p11, r=GuillaumeGomez

normalize use of backticks in compiler messages for librustc_metadata

rust-lang#60532
@Centril Centril mentioned this pull request Jul 21, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 22, 2019
@Centril
Rollup merge of rust-lang#62812 - fakenine:normalize_use_of_backticks…
063268b 
…_compiler_messages_p11, r=GuillaumeGomez

normalize use of backticks in compiler messages for librustc_metadata

rust-lang#60532
@Centril Centril mentioned this pull request Jul 22, 2019
Merged
bors added a commit that referenced this pull request Jul 22, 2019
@bors
Auto merge of #62873 - Centril:rollup-ncnuelj, r=Centril
e649e90 
Rollup of 14 pull requests

Successful merges:

 - #62709 (Test that maplike FromIter satisfies uniqueness)
 - #62713 (Stabilize <*mut _>::cast and <*const _>::cast)
 - #62746 ( do not use assume_init in std::io)
 - #62787 (Fix typo in src/libstd/net/udp.rs doc comment)
 - #62788 (normalize use of backticks in compiler messages for libcore/ptr)
 - #62799 (use const array repeat expressions for uninit_array)
 - #62810 (normalize use of backticks in compiler messages for librustc_lint)
 - #62812 (normalize use of backticks in compiler messages for librustc_metadata)
 - #62832 (normalize use of backticks in compiler messages for librustc_incremental)
 - #62845 (read: fix doc comment)
 - #62853 (normalize use of backticks in compiler messages for librustc/hir)
 - #62854 (Fix typo in Unicode character name)
 - #62858 (Change wrong variable name.)
 - #62870 (fix lexing of comments with many \r)

Failed merges:

r? @ghost
@bors bors merged commit 19a848d into rust-lang:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fakenine @rust-highfive @GuillaumeGomez @bors @eddyb @Centril