Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for issue-58887 #62842

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Add tests for issue-58887 #62842

merged 2 commits into from
Jul 23, 2019

Conversation

JohnTitor
Copy link
Member

Closes #58887

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2019
@alexreg
Copy link
Contributor

alexreg commented Jul 21, 2019 •
edited
Loading

Thanks for this @JohnTitor! Two small things:

  • Let's rename the assoc. ty II to something else like Iter, just for readability.
  • Let's move the test files (.rs and .stderr) to src/test/ui/existential-type/ui.

Be sure to re-bless, either with the command or manually.

After that, happy to merge. :-)

@alexreg
Copy link
Contributor

alexreg commented Jul 21, 2019

r? @alexreg

@JohnTitor
Copy link
Member Author

Renamed II to Iter and moved them into src/test/ui/existential-type/ (really src/test/ui/existential-type/ui?).

@alexreg
Copy link
Contributor

alexreg commented Jul 22, 2019

@JohnTitor Yep, that was an accident re the path.

@alexreg
Copy link
Contributor

alexreg commented Jul 22, 2019

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jul 22, 2019

📌 Commit e75ae15 has been approved by alexreg

@bors
Copy link
Contributor

bors commented Jul 22, 2019

🌲 The tree is currently closed for pull requests below priority 1500, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 22, 2019
@Centril
Rollup merge of rust-lang#62842 - JohnTitor:test-for-58887, r=alexreg
f7621c5 
Add tests for issue-58887

Closes rust-lang#58887
@Centril Centril mentioned this pull request Jul 22, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 23, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62842 - JohnTitor:test-for-58887, r=alexreg
8afc53c 
Add tests for issue-58887

Closes rust-lang#58887
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 23, 2019
Merged
bors added a commit that referenced this pull request Jul 23, 2019
@bors
Auto merge of #62902 - Mark-Simulacrum:rollup-mxfk0mm, r=Mark-Simulacrum
a7f2867 
Rollup of 14 pull requests

Successful merges:

 - #60951 (more specific errors in src/librustc/mir/interpret/error.rs)
 - #62523 (Delay bug to resolve HRTB ICE)
 - #62656 (explain how to search in slice without owned data)
 - #62791 (Handle more cases of typos misinterpreted as type ascription)
 - #62804 (rustc_typeck: improve diagnostics for _ const/static declarations)
 - #62808 (Revert "Disable stack probing for gnux32.")
 - #62817 (Tweak span for variant not found error)
 - #62842 (Add tests for issue-58887)
 - #62851 (move unescape module to rustc_lexer)
 - #62859 (Place::as_place_ref is now Place::as_ref)
 - #62869 (add rustc_private as a proper language feature gate)
 - #62880 (normalize use of backticks in compiler messages for librustc_allocator)
 - #62885 (Change "OSX" to "macOS")
 - #62889 (Update stage0.txt)

Failed merges:

r? @ghost
@bors bors merged commit e75ae15 into rust-lang:master Jul 23, 2019
@JohnTitor JohnTitor deleted the test-for-58887 branch July 24, 2019 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexreg alexreg

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE in typeck on existential return type in trait
5 participants
@JohnTitor @rust-highfive @alexreg @bors @nikomatsakis