Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

legacy_directory_ownership -> hard error #63241

Closed
wants to merge 1 commit into from
Closed

legacy_directory_ownership -> hard error #63241

wants to merge 1 commit into from

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Aug 3, 2019 •
edited
Loading

Closes #37872.

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2019
@bors
Copy link
Contributor

bors commented Aug 3, 2019

☔ The latest upstream changes (presumably #63234) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss
Copy link
Contributor

ehuss commented Aug 3, 2019

Apologies for butting in, but I have some questions about this.
Is this code path even possible? I can't find any UI tests, and I can't figure out a way to trigger it. It looks to have been mostly removed in #46531. The original tests were further removed via #47298.

@Centril
Copy link
Contributor Author

Centril commented Aug 3, 2019

I have no idea; I was also surprised there were no tests... I guess crater will show if anyone uses it or not =)

@ehuss
Copy link
Contributor

ehuss commented Aug 3, 2019

AFAICT, there are two places where UnownedViaMod can be created: submod_path and InvocationCollector. Both only seem to create it when there is a valid #[path] attribute with a value that fails to produce a file_name() or to_str(), both which shouldn't be possible AFAIK (that is, invalid unicode, or an empty string or root path, all which should fail in other ways).

@Centril
Copy link
Contributor Author

Centril commented Aug 3, 2019

Rolled up into #63247.

@Centril Centril closed this Aug 3, 2019
@Centril Centril deleted the ldo-error branch August 3, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

legacy_directory_ownership future-compatibility warnings
5 participants
@Centril @bors @ehuss @petrochenkov @rust-highfive