Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when generator trait is not found #63917

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Aug 26, 2019

Closes #63912

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2019
@rust-highfive

This comment has been minimized.

src/librustc_typeck/check/closure.rs Outdated Show resolved Hide resolved
src/test/compile-fail/no-core-gen-trait.rs Outdated Show resolved Hide resolved
@cramertj
Copy link
Member

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned cramertj Aug 26, 2019
@Centril
Copy link
Contributor

Centril commented Aug 26, 2019

r=Centril,cramertj rollup when-green and comment above addressed.

@Kixiron Kixiron added A-coroutines Area: Coroutines S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2019
@cramertj
Copy link
Member

@bors r=centril,cramert

@bors
Copy link
Contributor

bors commented Aug 26, 2019

📌 Commit fa7ea10 has been approved by centril,cramert

Centril added a commit to Centril/rust that referenced this pull request Aug 27, 2019
…l,cramert

Error when generator trait is not found

Closes rust-lang#63912
Centril added a commit to Centril/rust that referenced this pull request Aug 27, 2019
…l,cramert

Error when generator trait is not found

Closes rust-lang#63912
bors added a commit that referenced this pull request Aug 27, 2019
Rollup of 4 pull requests

Successful merges:

 - #62600 (libtest: add --show-output flag to print stdout of successful tests)
 - #63698 (Fixed floating point issue with asinh function)
 - #63761 (Propagate spans and attributes from proc macro definitions)
 - #63917 (Error when generator trait is not found)

Failed merges:

r? @ghost
@bors bors merged commit fa7ea10 into rust-lang:master Aug 27, 2019
@tesuji tesuji deleted the langitem_gen_63912 branch August 27, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-coroutines Area: Coroutines S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustc should error instead of panic when the generator trait is not found
6 participants