update mem::discriminant test to use assert_eq and assert_ne over comparison operators #64717
Conversation
Use assert_eq and assert_ne over comparison operators.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The change looks reasonable. However, could you please use a more descriptive subject than "update test"? Don't leave all the details to the body of the commit message. r=me (and bors rollup) with that fixed. |
andrewbanchich
changed the title
|
@joshtriplett Sure, all set! Let me know if you need anything else. r? @joshtriplett |
|
@andrewbanchich: 🔑 Insufficient privileges: Not in reviewers |
|
@andrewbanchich: 🔑 Insufficient privileges: not in try users |
|
Whoops, so you meant I should add |
|
@andrewbanchich: 🔑 Insufficient privileges: Not in reviewers |
|
@bors r=joshtriplett rollup |
|
📌 Commit 8acf958 has been approved by |
bors
added
S-waiting-on-bors
|
@andrewbanchich r=me generally means that someone with approval rights can do r=reviewer but if you don't have approval rights then you'll have to wait. |
update mem::discriminant test to use assert_eq and assert_ne over comparison operators Use assert_eq and assert_ne over comparison operators.
update mem::discriminant test to use assert_eq and assert_ne over comparison operators Use assert_eq and assert_ne over comparison operators.
Rollup of 16 pull requests Successful merges: - #63356 (Issue#63183: Add fs::read_dir() and ReadDir warning about iterator order + example) - #63934 (Fix coherence checking for impl trait in type aliases) - #64016 (Streamline `Compiler`) - #64296 (Document the unstable iter_order_by library feature) - #64443 (rustdoc: general cleanup) - #64622 (Add a cycle detector for generic `Graph`s and `mir::Body`s) - #64689 (Refactor macro by example) - #64698 (Recover on `const X = 42;` and infer type + Error Stash API) - #64702 (Remove unused dependencies) - #64717 (update mem::discriminant test to use assert_eq and assert_ne over comparison operators) - #64720 ( remove rtp.rs, and move rtpSpawn and RTP_ID_ERROR to libc) - #64721 (Fixed issue from #64447) - #64725 (fix one typo) - #64737 (fix several issues in String docs) - #64742 (relnotes: make compatibility section more sterile and fix rustc version) - #64748 (Fix #64744. Account for the Zero sub-pattern case.) Failed merges: r? @ghost
Use assert_eq and assert_ne over comparison operators.