Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For dylib crates, warn about GNU ld <=2.28 #66839

Closed
wants to merge 4 commits into from
Closed

For dylib crates, warn about GNU ld <=2.28 #66839

wants to merge 4 commits into from

Commits on Dec 4, 2019

  1. A heuristic diagnostic to try to help prevent issues related to old G… 

    …NU ld bugs like issue 61539.
    @pnkfelix
    pnkfelix committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    d635392 View commit details
    Browse the repository at this point in the history

  2. Refine warning to fire *solely* on dylib, not (dylib|proc-macro), to … 

    …reduce false-positive rate.
    @pnkfelix
    pnkfelix committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    a29d805 View commit details
    Browse the repository at this point in the history

  3. revised version parsing to handle arbitrary leading strings, rather t… 

    …han assuming it starts with "GNU ld version "
    @pnkfelix
    pnkfelix committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    357542f View commit details
    Browse the repository at this point in the history

  4. Explicitly check that we are looking at GNU ld, and otherwise skip th… 

    …e check.

(The first version of the PR had this implicitly by always searching for the
string literal "GNU ld version " when looking for where to start the search for
the version number.)
    @pnkfelix
    pnkfelix committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    c4a76c4 View commit details
    Browse the repository at this point in the history