(Mostly) finish formatting the repository #67596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustfmt tries its best already, we should not fight with it.
Use #[rustfmt::skip] on the tidy-parsed macro invocations
Mark-Simulacrum
changed the title
|
@bors r+ p=200 rollup=never |
|
📌 Commit 8d6d0e7 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 25, 2019
(Mostly) finish formatting the repository Silences tidy line length warnings on rustfmt-controlled files. This leaves two things out of formatting: CloudABI (mostly because it's not really ours to control, it's upstream code that's mostly generated), and tests. The latter is a hard problem and maybe not one to worry too much about, we rarely edit old tests and reformatting them as we go if possible isn't too bad (they're generally small).
|
☀️ Test successful - checks-azure |
This was referenced Dec 25, 2019
RalfJung
reviewed
Jan 3, 2020
Comment on lines
+395
to
+401
| // An extern type at offset 0, we fall back to its static alignment. | ||
| // FIXME: Once we have made decisions for how to handle size and alignment | ||
| // of `extern type`, this should be adapted. It is just a temporary hack | ||
| // to get some code to work that probably ought to work. | ||
| { | ||
| field_layout.align.abi | ||
| } |
There was a problem hiding this comment.
This looks pretty odd, in particular with the comment... any chance we could set match_arm_blocks = false to avoid this?
There was a problem hiding this comment.
I believe we're trying to stay as close to defaults as possible, but I would personally not be opposed to such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silences tidy line length warnings on rustfmt-controlled files.
This leaves two things out of formatting: CloudABI (mostly because it's not really ours to control, it's upstream code that's mostly generated), and tests. The latter is a hard problem and maybe not one to worry too much about, we rarely edit old tests and reformatting them as we go if possible isn't too bad (they're generally small).