Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the barrier cache during ARM EHABI unwinding #67779

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Jan 1, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

Do we need to beta-nominate this?

@bors
Copy link
Contributor

bors commented Jan 1, 2020

📌 Commit 057ad39 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2020
@Amanieu
Copy link
Member Author

Amanieu commented Jan 1, 2020

I don't think that's necessary, at the moment it's just a test failure on ARM targets (tier-2 so we don't block releases on test failures). Also FFI unwinding is still officially UB according to the docs.

@bors
Copy link
Contributor

bors commented Jan 2, 2020

⌛ Testing commit 057ad39 with merge 766fba3...

bors added a commit that referenced this pull request Jan 2, 2020
Update the barrier cache during ARM EHABI unwinding

Fixes #67242

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Jan 2, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 766fba3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 2, 2020
@bors bors merged commit 057ad39 into rust-lang:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run-make-fulldeps/foreign-exceptions loops on armv7-unknown-linux-gnueabihf
5 participants