Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix ICE #68025 #68069

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Attempt to fix ICE #68025 #68069

merged 2 commits into from
Jan 22, 2020

Conversation

JohnTitor
Copy link
Member

Fixes #68025

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2020
@Centril
Copy link
Contributor

Centril commented Jan 9, 2020

r? @matthewjasper cc @pnkfelix @nikomatsakis

@matthewjasper
Copy link
Contributor

I was trying to work out why this was working, since it appears to treat all closures as FnOnce. However, for non-FnOnce closures there will be an adjustment so the type of the callee will be & mut? [closure].

So the call to walk_callee should be replaced with consume_expr(callee) and any now dead code removed.

@JohnTitor
Copy link
Member Author

@matthewjasper Thanks! It seems so, addressed via 0017f49

@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 22, 2020

📌 Commit 0017f49 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2020
@bors
Copy link
Contributor

bors commented Jan 22, 2020

⌛ Testing commit 0017f49 with merge ae66171...

bors added a commit that referenced this pull request Jan 22, 2020
@bors
Auto merge of #68069 - JohnTitor:fix-closure-ice, r=matthewjasper
ae66171 
Attempt to fix ICE #68025

Fixes #68025
@bors bors mentioned this pull request Jan 22, 2020
Merged
@bors
Copy link
Contributor

bors commented Jan 22, 2020

☀️ Test successful - checks-azure
Approved by: matthewjasper
Pushing ae66171 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 22, 2020
@bors bors merged commit 0017f49 into rust-lang:master Jan 22, 2020
@JohnTitor JohnTitor deleted the fix-closure-ice branch January 22, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: no type-dependent def or overloaded call
6 participants
@JohnTitor @rust-highfive @Centril @matthewjasper @bors @cramertj