Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move generic arg/param validation to create_substs_for_generic_args to resolve various const generics issues #68434

Merged
merged 12 commits into from
Feb 27, 2020
Merged

Move generic arg/param validation to create_substs_for_generic_args to resolve various const generics issues #68434

merged 12 commits into from
Feb 27, 2020

Commits on Feb 22, 2020

  1. Return whether check_generic_arg_count finds an error

    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    2a50487 View commit details
    Browse the repository at this point in the history

  2. Report all errors in check_generic_arg_count

    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    d232acd View commit details
    Browse the repository at this point in the history

  3. Correct passing of generic_args to create_substs_for_generic_args

    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    9939de2 View commit details
    Browse the repository at this point in the history

  4. Report late-bound region lint as error in check_generic_arg_count

    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    750e673 View commit details
    Browse the repository at this point in the history

  5. Move generic arg / param validation to create_substs_for_generic_args

    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    039045c View commit details
    Browse the repository at this point in the history

  6. Refactor create_substs_for_generic_args a little

    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    c9b7b1f View commit details
    Browse the repository at this point in the history

  7. Make return value of check_generic_arg_count semantically clearer

    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    dff64eb View commit details
    Browse the repository at this point in the history

  8. Use Result instead of bool throughout

    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    104131c View commit details
    Browse the repository at this point in the history

  9. Be explicit about whether GenericArgCountMismatch arose from a fata… 

    …l error
    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    33143fd View commit details
    Browse the repository at this point in the history

  10. Add invalid argument spans to GenericArgCountMismatch

    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    76fb26b View commit details
    Browse the repository at this point in the history

  11. Expand the documentation for E0747

    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    e372ad4 View commit details
    Browse the repository at this point in the history

  12. Add note regarding argument ordering

    @varkor
    varkor committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    bead79e View commit details
    Browse the repository at this point in the history