Rollup of 5 pull requests #68771
Merged
Rollup of 5 pull requests #68771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated the example of the `expect` examples so they won't contain depressing sentences any more !
Update option.rs I updated the example of the `expect` examples so they won't contain depressing sentences any more !
Issue error on `compile-fail` header in UI test Fixes rust-lang#68732 r? @Centril
…=estebank Do not suggest duplicate bounds Fixes rust-lang#68205 Fixes rust-lang#68695 r? @estebank
parser: syntactically allow `self` in all `fn` contexts Part of rust-lang#68728. `self` parameters are now *syntactically* allowed as the first parameter irrespective of item context (and in function pointers). Instead, semantic validation (`ast_validation`) is used. r? @petrochenkov
parser: avoid re-wrapping NtItem r? @petrochenkov
|
@bors r+ p=5 rollup=never |
|
📌 Commit 011fb23 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 2, 2020
Rollup of 5 pull requests Successful merges: - #68733 (Update option.rs) - #68760 (Issue error on `compile-fail` header in UI test) - #68763 (Do not suggest duplicate bounds) - #68764 (parser: syntactically allow `self` in all `fn` contexts) - #68769 (parser: avoid re-wrapping NtItem) Failed merges: r? @ghost
|
☀️ Test successful - checks-azure |
This was referenced Feb 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
compile-failheader in UI test #68760 (Issue error oncompile-failheader in UI test)selfin allfncontexts #68764 (parser: syntactically allowselfin allfncontexts)Failed merges:
r? @ghost