Fix printing of Yield terminator
#69200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Zoxc |
eddyb
approved these changes
Feb 16, 2020
|
@bors r+ |
|
📌 Commit 759526e has been approved by |
bors
added
S-waiting-on-bors
Zoxc
reviewed
Feb 16, 2020
src/librustc/mir/mod.rs
Outdated
| Return => write!(fmt, "return"), | ||
| GeneratorDrop => write!(fmt, "generator_drop"), | ||
| Resume => write!(fmt, "resume"), | ||
| Abort => write!(fmt, "abort"), | ||
| Yield { ref value, .. } => write!(fmt, "_1 = suspend({:?})", value), | ||
| Yield { value, resume_arg, .. } => { | ||
| write!(fmt, "{:?} = suspend({:?})", resume_arg, value) |
There was a problem hiding this comment.
You can probably output yield instead of suspend. I think this was just missed during the Suspend to Yield rename.
|
@bors r=eddyb,Zoxc |
|
📌 Commit bb482eb has been approved by |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 16, 2020
…b,Zoxc Fix printing of `Yield` terminator Addresses the bug found in rust-lang#69039 (comment)
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 17, 2020
…b,Zoxc Fix printing of `Yield` terminator Addresses the bug found in rust-lang#69039 (comment)
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 18, 2020
…b,Zoxc Fix printing of `Yield` terminator Addresses the bug found in rust-lang#69039 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the bug found in #69039 (comment)