Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address concerns of weak-into-raw #71107

Merged
merged 2 commits into from
Apr 19, 2020
Merged

Address concerns of weak-into-raw #71107

merged 2 commits into from
Apr 19, 2020

Commits on Apr 13, 2020

  1. weak-into-raw: as_raw -> as_ptr + dangling garbage 

    * Rename Weak::as_raw to Weak::as_ptr for consistency with some other
  types.
* The as_ptr for a dangling Weak pointer might return whatever garbage
  (and takes that advantage to avoid a conditional).
* Don't guarantee to be able to do `Weak::from_raw(weak.as_ptr())` (even
  though it'll still work fine).
    @vorner
    vorner committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    80ccddc View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2020

  1. weak-into-raw: Add {Arc,Rc}::as_ptr 

    For consistency with Weak
    @vorner
    vorner committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    f4ded11 View commit details
    Browse the repository at this point in the history