Break tokens before checking if they are 'probably equal' #72306

Aaron1011 · 2020-05-17T19:55:19Z

When checking two TokenStreams to see if they are 'probably equal',
we ignore the IsJoint information associated with each TokenTree.
However, the IsJoint information determines whether adjacent tokens
will be 'glued' (if possible) when construction the TokenStream - e.g.
[Gt Gt] can be 'glued' to BinOp(Shr).

Since we are ignoring the IsJoint information, 'glued' and 'unglued'
tokens are equivalent for determining if two TokenStreams are
'probably equal'. Therefore, we need to 'unglue' all tokens in the
stream to avoid false negatives (which cause us to throw out the cached
tokens, losing span information).

rust-highfive · 2020-05-17T19:55:23Z

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

Aaron1011 · 2020-05-17T19:56:38Z

@bors try @rust-timer queue

rust-timer · 2020-05-17T19:56:39Z

Awaiting bors try build completion

bors · 2020-05-17T19:56:49Z

⌛ Trying commit 84b0397805132b435699c525b91cfcb5f1bf7c3a with merge f24b9a57e2c4ea08ca739037ce291dbd3e2e2708...

rust-highfive · 2020-05-17T21:11:47Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux mingw-check
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 65'
Agent machine name: 'fv-az578'
Current agent version: '2.168.2'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200430.2
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200430.2/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.2)
Checking job knob settings.
   Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} 
   Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} 
Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/4bcdfe9d-1974-465b-9ac1-011373de3156.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/72306/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/72306/merge:refs/remotes/pull/72306/merge
---
 ---> 3adb0605cc65
Step 6/7 : ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
 ---> Using cache
 ---> 28dbc326cb7f
Step 7/7 : ENV SCRIPT python3 ../x.py test src/tools/expand-yaml-anchors &&            python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu &&            python3 ../x.py build --stage 0 src/tools/build-manifest &&            python3 ../x.py test --stage 0 src/tools/compiletest &&            python3 ../x.py test src/tools/tidy &&            python3 ../x.py doc --stage 0 src/libstd &&            /scripts/validate-toolstate.sh
 ---> 537a01811900
Successfully built 537a01811900
Successfully tagged rust-ci:latest
Built container sha256:537a018119009dc218456238dec90b5530050db1e2a1e166550c218003f6159d
---
    Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
    Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
    Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
    Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
    Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
    Checking chalk-rust-ir v0.10.0
    Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
    Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
    Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
configure: dist.missing-tools   := True
configure: rust.dist-src        := False
configure: rust.debug-assertions := True
configure: llvm.assertions      := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
Hugepagesize:       2048 kB
DirectMap4k:      131008 kB
DirectMap2M:     5111808 kB
DirectMap1G:     4194304 kB
+ python3 ../x.py test src/tools/expand-yaml-anchors
Ensuring the YAML anchors in the GitHub Actions config were expanded
Ensuring the YAML anchors in the GitHub Actions config were expanded
Building stage0 tool expand-yaml-anchors (x86_64-unknown-linux-gnu)
   Compiling unicode-xid v0.2.0
   Compiling syn v1.0.11
   Compiling linked-hash-map v0.5.2
   Compiling lazy_static v1.4.0
   Compiling lazy_static v1.4.0
   Compiling yaml-rust v0.4.3
   Compiling quote v1.0.2
   Compiling thiserror-impl v1.0.5
   Compiling thiserror v1.0.5
   Compiling yaml-merge-keys v0.4.0
   Compiling expand-yaml-anchors v0.1.0 (/checkout/src/tools/expand-yaml-anchors)
Build completed successfully in 0:00:31
+ python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu
    Finished dev [unoptimized] target(s) in 0.22s
Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
---
    Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
    Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
    Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
    Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
    Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
    Checking chalk-rust-ir v0.10.0
    Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
    Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
    Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
skip untracked path cpu-usage.csv during rustfmt invocations
skip untracked path src/doc/book/ during rustfmt invocations
skip untracked path src/doc/rust-by-example/ during rustfmt invocations
skip untracked path src/llvm-project/ during rustfmt invocations
Diff in /checkout/src/librustc_ast/tokenstream.rs at line 360:
         fn break_tokens(tree: TokenTree) -> impl Iterator<Item = TokenTree> {
             if let TokenTree::Token(token) = &tree {
                 if let Some((first, second)) = token.kind.break_two_token_op() {
-                    return SmallVec::from_buf([TokenTree::Token(Token::new(first, DUMMY_SP)), TokenTree::Token(Token::new(second, DUMMY_SP))]).into_iter()
+                    return SmallVec::from_buf([
+                        TokenTree::Token(Token::new(first, DUMMY_SP)),
+                        TokenTree::Token(Token::new(second, DUMMY_SP)),
+                    ])
                 }
             }
             }
             let mut vec = SmallVec::<[_; 2]>::new();
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/src/librustc_ast/tokenstream.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
Build completed unsuccessfully in 0:00:38
== clock drift check ==
  local time: Sun May 17 20:16:56 UTC 2020
  network time: Sun, 17 May 2020 20:16:56 GMT
  network time: Sun, 17 May 2020 20:16:56 GMT
== end clock drift check ==

##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/72306/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/72306/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (3545) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-05-17T22:48:15Z

☀️ Try build successful - checks-azure
Build commit: f24b9a57e2c4ea08ca739037ce291dbd3e2e2708 (f24b9a57e2c4ea08ca739037ce291dbd3e2e2708)

rust-timer · 2020-05-17T22:48:16Z

Queued f24b9a57e2c4ea08ca739037ce291dbd3e2e2708 with parent d79f1bd, future comparison URL.

rust-timer · 2020-05-18T03:15:48Z

Finished benchmarking try commit f24b9a57e2c4ea08ca739037ce291dbd3e2e2708, comparison URL.

Fixes rust-lang#68489 When checking two `TokenStreams` to see if they are 'probably equal', we ignore the `IsJoint` information associated with each `TokenTree`. However, the `IsJoint` information determines whether adjacent tokens will be 'glued' (if possible) when construction the `TokenStream` - e.g. `[Gt Gt]` can be 'glued' to `BinOp(Shr)`. Since we are ignoring the `IsJoint` information, 'glued' and 'unglued' tokens are equivalent for determining if two `TokenStreams` are 'probably equal'. Therefore, we need to 'unglue' all tokens in the stream to avoid false negatives (which cause us to throw out the cached tokens, losing span information).

Some tokens need to be broken in a loop until we reach 'unbreakable' tokens.

rust-highfive · 2020-05-20T00:54:05Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux mingw-check
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 7'
Agent machine name: 'fv-az578'
Current agent version: '2.168.2'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200512.2
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200512.2/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.2)
Checking job knob settings.
   Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} 
   Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} 
Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/aaba5423-9009-45ba-9831-3084a7794670.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/72306/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/72306/merge:refs/remotes/pull/72306/merge
---
 ---> 3adb0605cc65
Step 6/7 : ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
 ---> Using cache
 ---> 28dbc326cb7f
Step 7/7 : ENV SCRIPT python3 ../x.py test src/tools/expand-yaml-anchors &&            python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu &&            python3 ../x.py build --stage 0 src/tools/build-manifest &&            python3 ../x.py test --stage 0 src/tools/compiletest &&            python3 ../x.py test src/tools/tidy &&            python3 ../x.py doc --stage 0 src/libstd &&            /scripts/validate-toolstate.sh
 ---> 537a01811900
Successfully built 537a01811900
Successfully tagged rust-ci:latest
Built container sha256:537a018119009dc218456238dec90b5530050db1e2a1e166550c218003f6159d
---
    Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
    Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
    Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
    Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
    Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
    Checking chalk-rust-ir v0.10.0
    Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
    Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
    Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
configure: rust.debug-assertions := True
configure: rust.channel         := nightly
configure: rust.dist-src        := False
configure: build.submodules     := False
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
Hugepagesize:       2048 kB
DirectMap4k:      135104 kB
DirectMap2M:     6156288 kB
DirectMap1G:     3145728 kB
+ python3 ../x.py test src/tools/expand-yaml-anchors
Ensuring the YAML anchors in the GitHub Actions config were expanded
Ensuring the YAML anchors in the GitHub Actions config were expanded
Building stage0 tool expand-yaml-anchors (x86_64-unknown-linux-gnu)
   Compiling unicode-xid v0.2.0
   Compiling syn v1.0.11
   Compiling linked-hash-map v0.5.2
   Compiling lazy_static v1.4.0
   Compiling lazy_static v1.4.0
   Compiling yaml-rust v0.4.3
   Compiling quote v1.0.2
   Compiling thiserror-impl v1.0.5
   Compiling thiserror v1.0.5
   Compiling yaml-merge-keys v0.4.0
   Compiling expand-yaml-anchors v0.1.0 (/checkout/src/tools/expand-yaml-anchors)
Build completed successfully in 0:00:24
+ python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu
    Finished dev [unoptimized] target(s) in 0.18s
Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
---
    Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
    Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
    Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
    Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
    Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
    Checking chalk-rust-ir v0.10.0
    Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
    Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
    Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
   Compiling cargo_metadata v0.9.1
   Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
    Finished release [optimized] target(s) in 20.71s
tidy check
tidy error: /checkout/src/test/ui/proc-macro/break-token-spans.rs:5: trailing whitespace
some tidy checks failed
Found 493 error codes
Found 0 error codes with no tests
Done!
Done!


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
Build completed unsuccessfully in 0:00:30
Build completed unsuccessfully in 0:00:30
== clock drift check ==
  local time: Wed May 20 00:05:38 UTC 2020
  network time: Wed, 20 May 2020 00:05:38 GMT
== end clock drift check ==

##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/72306/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/72306/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (4530) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

petrochenkov · 2020-05-20T19:10:07Z

Yeah, let's pile up hacks on top of hacks so the hack mountain obscures the Sun.
@bors r+

bors · 2020-05-20T19:10:09Z

📌 Commit 4a8ccdc has been approved by petrochenkov

bors · 2020-05-20T19:10:09Z

🌲 The tree is currently closed for pull requests below priority 9000, this pull request will be tested once the tree is reopened

petrochenkov · 2020-05-20T19:11:59Z

Wait, from the prettified log it looked like the CI failure was spurious, but it is not.
@bors r-

r=me with green CI

Aaron1011 · 2020-05-20T19:34:53Z

@petrochenkov: Fixed

…petrochenkov Break tokens before checking if they are 'probably equal' Fixes rust-lang#68489 Fixes rust-lang#70987 When checking two `TokenStreams` to see if they are 'probably equal', we ignore the `IsJoint` information associated with each `TokenTree`. However, the `IsJoint` information determines whether adjacent tokens will be 'glued' (if possible) when construction the `TokenStream` - e.g. `[Gt Gt]` can be 'glued' to `BinOp(Shr)`. Since we are ignoring the `IsJoint` information, 'glued' and 'unglued' tokens are equivalent for determining if two `TokenStreams` are 'probably equal'. Therefore, we need to 'unglue' all tokens in the stream to avoid false negatives (which cause us to throw out the cached tokens, losing span information).

petrochenkov · 2020-05-21T17:30:13Z

@bors try @rust-timer queue

bors · 2020-05-21T17:30:15Z

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

rust-timer · 2020-05-21T17:30:15Z

Awaiting bors try build completion

petrochenkov · 2020-05-21T17:30:34Z

@bors r-
@bors try @rust-timer queue

rust-timer · 2020-05-21T17:30:35Z

Awaiting bors try build completion

bors · 2020-05-21T17:30:46Z

⌛ Trying commit 633293f with merge ede22bd73291f6dfc8c10cd9a59926946698b987...

bors · 2020-05-21T20:10:39Z

☀️ Try build successful - checks-azure
Build commit: ede22bd73291f6dfc8c10cd9a59926946698b987 (ede22bd73291f6dfc8c10cd9a59926946698b987)

rust-timer · 2020-05-21T20:10:40Z

Queued ede22bd73291f6dfc8c10cd9a59926946698b987 with parent 06c9fef, future comparison URL.

rust-timer · 2020-05-21T22:42:32Z

Finished benchmarking try commit ede22bd73291f6dfc8c10cd9a59926946698b987, comparison URL.

Aaron1011 · 2020-05-21T22:45:30Z

@petrochenkov: There appears to be no perf impact

petrochenkov · 2020-05-22T06:09:48Z

@bors r+

bors · 2020-05-22T06:09:49Z

📌 Commit 633293f has been approved by petrochenkov

@ghost

Rollup of 4 pull requests Successful merges: - rust-lang#71610 (InvalidUndefBytes: Track size of undef region used) - rust-lang#72161 (Replace fcntl-based file lock with flock) - rust-lang#72306 (Break tokens before checking if they are 'probably equal') - rust-lang#72325 (Always generated object code for `#![no_builtins]`) Failed merges: r? @ghost

rust-highfive assigned petrochenkov May 17, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2020

Aaron1011 mentioned this pull request May 18, 2020

Rustc does display a correct error message on type missmatch but does not show line numbers #51635

Closed

Aaron1011 force-pushed the feature/turbo-spacing branch from 84b0397 to a3e7825 Compare May 19, 2020 23:46

Use a fixed-point iteration when breaking tokens

4a8ccdc

Some tokens need to be broken in a loop until we reach 'unbreakable' tokens.

Aaron1011 force-pushed the feature/turbo-spacing branch from a3e7825 to 4a8ccdc Compare May 19, 2020 23:47

Aaron1011 mentioned this pull request May 19, 2020

mismatched types error without location info #70987

Closed

This was referenced May 20, 2020

Improperly reported compilation errors when using async_trait dtolnay/async-trait#91

Closed

incorrect use led to compile error with no location information dtolnay/async-trait#95

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 20, 2020

Fix tests

633293f

Dylan-DPC-zz mentioned this pull request May 20, 2020

Rollup of 6 pull requests #72403

Closed

anp mentioned this pull request May 21, 2020

Figure out where topo::nested is losing spans anp/moxie#123

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 21, 2020

petrochenkov added S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 21, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 22, 2020

petrochenkov removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 22, 2020

RalfJung mentioned this pull request May 22, 2020

Rollup of 4 pull requests #72460

Merged

bors merged commit 62d4e9e into rust-lang:master May 22, 2020

Aaron1011 mentioned this pull request May 25, 2020

Compiler loses location information before calling macros (sometimes) #43081

Closed

taiki-e mentioned this pull request Jun 25, 2020

Instrumenting async_trait methods drops location of compilation errors tokio-rs/tracing#768

Closed

This was referenced Jul 4, 2020

Bad suggestion dyn pub on proc macro (#61963 regressed) #74043

Open

std::line macro can be wrong in 1.44.1 stable under proc-macros #74035

Open

estebank mentioned this pull request Sep 19, 2020

Compiler error message is confusing #64829

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Break tokens before checking if they are 'probably equal' #72306

Break tokens before checking if they are 'probably equal' #72306

Aaron1011 commented May 17, 2020 •

edited

Loading

rust-highfive commented May 17, 2020

Aaron1011 commented May 17, 2020

rust-timer commented May 17, 2020

bors commented May 17, 2020

rust-highfive commented May 17, 2020

bors commented May 17, 2020

rust-timer commented May 17, 2020

rust-timer commented May 18, 2020

rust-highfive commented May 20, 2020

petrochenkov commented May 20, 2020

bors commented May 20, 2020

bors commented May 20, 2020

petrochenkov commented May 20, 2020

Aaron1011 commented May 20, 2020

petrochenkov commented May 21, 2020

bors commented May 21, 2020

rust-timer commented May 21, 2020

petrochenkov commented May 21, 2020

rust-timer commented May 21, 2020

bors commented May 21, 2020

bors commented May 21, 2020

rust-timer commented May 21, 2020

rust-timer commented May 21, 2020

Aaron1011 commented May 21, 2020

petrochenkov commented May 22, 2020

bors commented May 22, 2020

Break tokens before checking if they are 'probably equal' #72306

Break tokens before checking if they are 'probably equal' #72306

Conversation

Aaron1011 commented May 17, 2020 • edited Loading

rust-highfive commented May 17, 2020

Aaron1011 commented May 17, 2020

rust-timer commented May 17, 2020

bors commented May 17, 2020

rust-highfive commented May 17, 2020

bors commented May 17, 2020

rust-timer commented May 17, 2020

rust-timer commented May 18, 2020

rust-highfive commented May 20, 2020

petrochenkov commented May 20, 2020

bors commented May 20, 2020

bors commented May 20, 2020

petrochenkov commented May 20, 2020

Aaron1011 commented May 20, 2020

petrochenkov commented May 21, 2020

bors commented May 21, 2020

rust-timer commented May 21, 2020

petrochenkov commented May 21, 2020

rust-timer commented May 21, 2020

bors commented May 21, 2020

bors commented May 21, 2020

rust-timer commented May 21, 2020

rust-timer commented May 21, 2020

Aaron1011 commented May 21, 2020

petrochenkov commented May 22, 2020

bors commented May 22, 2020

Aaron1011 commented May 17, 2020 •

edited

Loading