Some renaming and minor refactoring for NativeLibraryKind
#72309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
mati865
reviewed
May 18, 2020
| /// Windows dynamic library (`foo.dll`) without a corresponding import library (`foo.lib`). | ||
| RawDylib, | ||
| /// A macOS-specific kind of dynamic libraries. | ||
| Framework, | ||
| /// The library kind wasn't specified, dynamic linking is currently preferred. | ||
| /// The library kind wasn't specified, `Dylib` is currently used as a default. |
There was a problem hiding this comment.
Hm I'm not sure I quite follow this comment -- when do we encounter Unspecified if dylib is the default? Or does this mean that (as I think) that currently when we encounter an unspecified library kind, we store it as unspecified, but the code treats it equivalently to Dylib?
If that's right, it seems like we might want to adjust this such that Dylib is instead something like Dylib { explicit: bool } perhaps? I'm not sure whether that's worthwhile though given how rarely we add things, but I'd be a bit concerned that over time we may not be actually treating unspecified entirely equivalently to unspecified.
petrochenkov
added
S-waiting-on-author
NativeLibrary(Kind) -> NativeLib(Kind) NativeStatic -> StaticBundle NativeStaticNobundle -> StaticNoBundle NativeFramework -> Framework NativeRawDylib -> RawDylib NativeUnknown -> Unspecified
petrochenkov
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 8dbe4d9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#71607 (clarify interaction of pin drop guarantee and panics) - rust-lang#72125 (remove broken link) - rust-lang#72133 (Add target thumbv7a-uwp-windows-msvc) - rust-lang#72304 (rustc_target: Avoid an inappropriate use of `post_link_objects`) - rust-lang#72309 (Some renaming and minor refactoring for `NativeLibraryKind`) - rust-lang#72438 (Enable ARM TME (Transactional Memory Extensions)) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.