Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to ensure Fuse stays covariant #72902

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jun 2, 2020

When #70502 attempted to specialize the data types in Fuse, one of the problems we found was that it broke variance. This was also realized when Fuse was first added, #35656 (diff), but now this PR adds a test so we don't forget again.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2020
@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 2, 2020

📌 Commit a3344d1 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 3, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#72704 (Remote testing fixes)
 - rust-lang#72820 (InstCombine: Don't optimize `&mut *x` into `x`)
 - rust-lang#72848 (Correct generic parameter ordering in error note for E0747)
 - rust-lang#72902 (Add a test to ensure Fuse stays covariant)
 - rust-lang#72921 (Add assert to Vec with_capacity docs)

Failed merges:

r? @ghost
@bors bors merged commit 0050b88 into rust-lang:master Jun 3, 2020
@cuviper cuviper deleted the fuse-covariant branch August 9, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants