Use min_specialization in libcore #73565

matthewjasper · 2020-06-20T22:15:58Z

Getting TrustedRandomAccess to work is the main interesting thing here.

get_unchecked is now an unstable, hidden method on Iterator
The contract for TrustedRandomAccess is made clearer in documentation
Fixed a bug where Debug would create aliasing references when using the specialized zip impl
Added tests for the side effects of next_back and nth.

closes #68536

rust-highfive · 2020-06-20T22:16:01Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

nagisa

Only made a very basic initial pass, got distracted before I could go through the whole PR.

src/libcore/str/mod.rs

nagisa · 2020-06-21T12:44:48Z

src/libcore/iter/adapters/zip.rs

+#[doc(hidden)]
+#[unstable(feature = "trusted_random_access", issue = "none")]
+#[rustc_specialization_trait]
+pub unsafe trait TrustedRandomAccess: Sized {


Why does this need to become pub?

It's now used in the interface of Iterator

nagisa · 2020-06-21T12:47:31Z

src/libcore/iter/adapters/zip.rs

+///
+/// `size` may not be overridden.
+///
+/// `<Self as Iterator>::get_unchecked` must be overridden. It must be safe to


Given that the default implementation simply panic!()s, this is not an unsafety invariant, is it?

bors · 2020-06-23T11:52:36Z

☔ The latest upstream changes (presumably #73643) made this pull request unmergeable. Please resolve the merge conflicts.

Muirrum · 2020-07-09T14:15:51Z

@rustbot modify labels to: +S-waiting-on-author -S-waiting-on-review

JohnTitor · 2020-08-05T02:49:23Z

Let's r? @nagisa as they left some review comments.

nagisa

@bors r+

nagisa · 2020-08-16T21:54:53Z

src/libcore/tests/iter.rs

+    assert_eq!(iter.next_back(), Some((40, 5000)));
+    assert_eq!(iter.next_back(), Some((30, 4000)));
+    assert_eq!(a, vec![6, 5, 4, 3]);
+    assert_eq!(b, vec![800, 700, 600, 500, 400]);


Do we actually want to enforce that the 2nd iterator consumes 1 more value than from the first iterator? I think this could go either way, but I would at least leave a comment to that effect so that a change in this behaviour wouldn’t immediately appear invalid.

nagisa · 2020-08-16T22:07:52Z

Oh well, this will need a rebase, but r=me once that's done.

Sorry for taking so long to get around to this.

matthewjasper · 2020-08-19T21:04:47Z

@bors r=nagisa

bors · 2020-08-19T21:04:48Z

📌 Commit dbad8c9 has been approved by nagisa

bors · 2020-08-19T22:21:50Z

⌛ Testing commit dbad8c9 with merge 1dc99bb058f144c8f4f64b005e546c10f301901b...

rust-log-analyzer · 2020-08-19T22:47:22Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Build completed successfully in 0:02:10
+ /scripts/validate-toolstate.sh
Cloning into 'rust-toolstate'...
<Nothing changed>
Traceback (most recent call last):
  File "../../src/tools/publish_toolstate.py", line 283, in <module>
    validate_maintainers(repo, github_token)
  File "../../src/tools/publish_toolstate.py", line 84, in validate_maintainers
    'Accept': 'application/vnd.github.hellcat-preview+json',
  File "/usr/lib/python3.6/urllib/request.py", line 223, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.6/urllib/request.py", line 532, in open
    response = meth(req, response)
  File "/usr/lib/python3.6/urllib/request.py", line 642, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.6/urllib/request.py", line 570, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 504, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Forbidden
  local time: Wed Aug 19 22:47:09 UTC 2020
  network time: Wed, 19 Aug 2020 22:47:09 GMT
== end clock drift check ==
== end clock drift check ==
##[error]Process completed with exit code 1.
Terminate orphan process: pid (6409) (node)
Terminate orphan process: pid (6433) (python)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-08-19T22:48:37Z

💔 Test failed - checks-actions

matthewjasper · 2020-08-20T06:47:14Z

@bors retry

bors · 2020-08-20T07:12:59Z

⌛ Testing commit dbad8c9 with merge 2f15b6b842776d00d2eb9369deeb7dcd1b3a3baa...

bors · 2020-08-20T09:22:32Z

💔 Test failed - checks-azure

matthewjasper · 2020-08-20T12:04:03Z

@bors retry

bors · 2020-08-20T23:05:37Z

⌛ Testing commit dbad8c9 with merge d9d4d39...

bors · 2020-08-21T00:57:11Z

☀️ Test successful - checks-actions, checks-azure
Approved by: nagisa
Pushing d9d4d39 to master...

the8472 · 2021-01-03T20:36:20Z

@matthewjasper I'm currently thinking how to extend TrustedRandomAccess to drop types, one piece I am currently not understanding is why __iterator_get_unchecked was moved from TrustedRandomAccess to Iterator but not its other methods.

matthewjasper · 2021-01-10T20:06:38Z

__iterator_get_unchecked was moved because it sometimes needs the bounds on the Iterator impl. The other methods were not because I wanted to minimize what was added to Iterator.

rust-highfive assigned cramertj Jun 20, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2020

nagisa reviewed Jun 21, 2020

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2020

crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2020

matthewjasper added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 25, 2020

rust-highfive assigned nagisa and unassigned cramertj Aug 5, 2020

nagisa approved these changes Aug 16, 2020

View reviewed changes

matthewjasper force-pushed the core-min-spec branch from 66b60da to 1a4d826 Compare August 17, 2020 19:14

Use min_specialization in libcore

dbad8c9

matthewjasper force-pushed the core-min-spec branch from 1a4d826 to dbad8c9 Compare August 19, 2020 19:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 19, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 20, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2020

bors mentioned this pull request Aug 21, 2020

specialize some collection and iterator operations to run in-place #70793

Merged

bors merged commit d9d4d39 into rust-lang:master Aug 21, 2020

matthewjasper deleted the core-min-spec branch August 21, 2020 07:06

cuviper added a commit to cuviper/rust that referenced this pull request Sep 5, 2020

Move ArrayChunksMut::get_unchecked per rust-lang#73565

86b9f71

cuviper mentioned this pull request Sep 5, 2020

Add slice::array_chunks_mut #75021

Merged

tesuji mentioned this pull request Sep 8, 2020

regression: get_unchecked resolves to unstable feature use #76479

Closed

steffahn mentioned this pull request Jun 1, 2021

Fix typo in internal documentation for TrustedRandomAccess #85888

Merged

the8472 mentioned this pull request Feb 5, 2023

Improve the array::map codegen #107634

Merged

cuviper added this to the 1.47.0 milestone May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use min_specialization in libcore #73565

Use min_specialization in libcore #73565

matthewjasper commented Jun 20, 2020

rust-highfive commented Jun 20, 2020

nagisa left a comment

nagisa Jun 21, 2020

matthewjasper Jun 21, 2020

nagisa Jun 21, 2020

bors commented Jun 23, 2020

Muirrum commented Jul 9, 2020

JohnTitor commented Aug 5, 2020

nagisa left a comment

nagisa Aug 16, 2020

nagisa commented Aug 16, 2020 •

edited

Loading

matthewjasper commented Aug 19, 2020

bors commented Aug 19, 2020

bors commented Aug 19, 2020

rust-log-analyzer commented Aug 19, 2020

bors commented Aug 19, 2020

matthewjasper commented Aug 20, 2020

bors commented Aug 20, 2020

bors commented Aug 20, 2020

matthewjasper commented Aug 20, 2020

bors commented Aug 20, 2020

bors commented Aug 21, 2020

the8472 commented Jan 3, 2021

matthewjasper commented Jan 10, 2021

Use min_specialization in libcore #73565

Use min_specialization in libcore #73565

Conversation

matthewjasper commented Jun 20, 2020

rust-highfive commented Jun 20, 2020

nagisa left a comment

Choose a reason for hiding this comment

nagisa Jun 21, 2020

Choose a reason for hiding this comment

matthewjasper Jun 21, 2020

Choose a reason for hiding this comment

nagisa Jun 21, 2020

Choose a reason for hiding this comment

bors commented Jun 23, 2020

Muirrum commented Jul 9, 2020

JohnTitor commented Aug 5, 2020

nagisa left a comment

Choose a reason for hiding this comment

nagisa Aug 16, 2020

Choose a reason for hiding this comment

nagisa commented Aug 16, 2020 • edited Loading

matthewjasper commented Aug 19, 2020

bors commented Aug 19, 2020

bors commented Aug 19, 2020

rust-log-analyzer commented Aug 19, 2020

bors commented Aug 19, 2020

matthewjasper commented Aug 20, 2020

bors commented Aug 20, 2020

bors commented Aug 20, 2020

matthewjasper commented Aug 20, 2020

bors commented Aug 20, 2020

bors commented Aug 21, 2020

the8472 commented Jan 3, 2021

matthewjasper commented Jan 10, 2021

nagisa commented Aug 16, 2020 •

edited

Loading