Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the ref keyword #73645

Merged
merged 3 commits into from
Jul 25, 2020
Merged

Document the ref keyword #73645

merged 3 commits into from
Jul 25, 2020

Conversation

poliorcetics
Copy link
Contributor

Partial fix for #34601.

This documents the ref keyword with two examples, one failing to compile because the ref keyword is missing, and the same example fixed with the keyword inserted in the correct place.

It also explains (very very rapidly) the differences between & and ref.

I put a link to the best place I could find in the Reference but there may be something better that I didn't find.

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2020
@poliorcetics
Copy link
Contributor Author

@rustbot modify labels: T-doc,C-enhancement

@rustbot rustbot added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Jun 23, 2020
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2020
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Show resolved Hide resolved
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once nits are fixed

src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Jul 24, 2020

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Jul 24, 2020

📌 Commit 79f052b has been approved by jyn514

@bors
Copy link
Contributor

bors commented Jul 24, 2020

🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2020
@bors
Copy link
Contributor

bors commented Jul 24, 2020

⌛ Testing commit 79f052b with merge 1e55f58...

@bors
Copy link
Contributor

bors commented Jul 25, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jyn514
Pushing 1e55f58 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 25, 2020
@bors bors merged commit 1e55f58 into rust-lang:master Jul 25, 2020
@poliorcetics poliorcetics deleted the ref-keyword branch July 25, 2020 08:30
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants