Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SymbolName::name to a &str. #74214

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Change SymbolName::name to a &str. #74214

merged 2 commits into from
Jul 15, 2020

Commits on Jul 15, 2020

  1. Change SymbolName::name to a &str. 

    This eliminates a bunch of `Symbol::intern()` and `Symbol::as_str()`
calls, which is good, because they require locking the interner.

Note that the unsafety in `from_cycle_error()` is identical to the
unsafety on other adjacent impls.
    @nnethercote
    nnethercote committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    7c4d431 View commit details
    Browse the repository at this point in the history

  2. Undo the const_str changes from the previous commit.

    @nnethercote
    nnethercote committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    a1b8540 View commit details
    Browse the repository at this point in the history