Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a couple of clippy findings #75270

Merged
merged 17 commits into from
Aug 8, 2020
Merged

fix a couple of clippy findings #75270

merged 17 commits into from
Aug 8, 2020

Commits on Aug 7, 2020

  1. fix clippy::expect_fun_call: use unwrap_or_else to prevent panic mess… 

    …age from always being evaluated
    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    3ef8c72 View commit details
    Browse the repository at this point in the history

  2. fix clippy::filter_next: use .find(..) instead of .filter(..).next()

    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    8bc1f91 View commit details
    Browse the repository at this point in the history

  3. fix clippy::iter_next_slice: use .get(0) instead of .iter().next()

    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    fca81fa View commit details
    Browse the repository at this point in the history

  4. fix clippy::map_identity: remove redundant .map(|x| x) call

    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    fb975cd View commit details
    Browse the repository at this point in the history

  5. fix clippy::redundant_clone: remove redundant clones

    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    27bb689 View commit details
    Browse the repository at this point in the history

  6. fix clippy::redundant_pattern_matching: use .is_some() instead of if … 

    …let Some(_) = ..
    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    09e29e7 View commit details
    Browse the repository at this point in the history

  7. fix clippy::single_char_pattern: use char instead of string single-ch… 

    …ar pattern
    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    f3ec5be View commit details
    Browse the repository at this point in the history

  8. fix clippy::unit_arg: make it explicit that Ok(()) is being returned

    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    a1c2212 View commit details
    Browse the repository at this point in the history

  9. fix clippy::unnecessary_mut_passed: function arg is not required to b… 

    …e mutable
    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    f6b1857 View commit details
    Browse the repository at this point in the history

  10. fix clippy::unneeded_wildcard_pattern: remove redundant wildcard pattern

    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    eccc2fe View commit details
    Browse the repository at this point in the history

  11. fix clippy::len_zero: use is_empty() instead of comparing .len() to zero

    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    057730c View commit details
    Browse the repository at this point in the history

  12. fix clippy::redundant_closure: remove redundant closures and call fun… 

    …ctions directly
    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    f95cfe5 View commit details
    Browse the repository at this point in the history

  13. fix clippy::while_let_loop: use while let{} instead of loop { if ... … 

    …break; }
    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    ea9ccfa View commit details
    Browse the repository at this point in the history

  14. fix clippy::into_iter_on_ref: use .iter() instead of into_iter() on r… 

    …eferences.
    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    4ba1a19 View commit details
    Browse the repository at this point in the history

  15. fix clippy::map_clone: use .cloned() instead of .map(|x| x.clone())

    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    15dcda3 View commit details
    Browse the repository at this point in the history

  16. fix clippy::clone_on_copy: don't clone types that are copy

    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    ff692ab View commit details
    Browse the repository at this point in the history

  17. fix clippy::needless_return: remove unneeded return statements

    @matthiaskrgr
    matthiaskrgr committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    a605e51 View commit details
    Browse the repository at this point in the history