Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix syntax error in suggesting generic constraint in trait parameter #76695

Merged
merged 2 commits into from
Sep 16, 2020
Merged

fix syntax error in suggesting generic constraint in trait parameter #76695

merged 2 commits into from
Sep 16, 2020

Commits on Sep 14, 2020

  1. fix syntax error in suggesting generic constraint in trait parameter 

    suggest `where T: Foo` for the first bound on a trait, then suggest
`, T: Foo` when the suggested bound would add to an existing set of
`where` clauses. `where T: Foo` may be the first bound if `T` has a
default, because we'd rather suggest
```
trait A<T=()> where T: Copy
```
than
```
trait A<T: Copy=()>
```
for legibility reasons.
    @iximeow
    iximeow committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    0eac38b View commit details
    Browse the repository at this point in the history

  2. clean up comment text a bit 

    Co-authored-by: Esteban Küber <esteban@kuber.com.ar>
    @iximeow @estebank
    iximeow and estebank committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    e1607c8 View commit details
    Browse the repository at this point in the history