Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #77926

Merged
merged 28 commits into from
Oct 14, 2020
Merged

Rollup of 8 pull requests #77926

merged 28 commits into from
Oct 14, 2020

Commits on Oct 9, 2020

  1. Configuration menu
    Copy the full SHA
    46f2f02 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Configuration menu
    Copy the full SHA
    69f45cd View commit details
    Browse the repository at this point in the history
  2. Move finalize_session_directory call out of cg_llvm

    This causes it to be called even when passing `-Zno-link`, when linking
    fails or when neither `--emit link` nor `--emit metadata` is used.
    bjorn3 committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    f141acf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bb9da7a View commit details
    Browse the repository at this point in the history
  4. Use fixed type for CodegenResults

    This also moves the -Zno-link implementation to rustc_interface
    bjorn3 committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    69f26b7 View commit details
    Browse the repository at this point in the history
  5. Move llvm_util::time_trace_profiler_finish call to join_codegen

    This makes it also run when compilation has failed, neither --emit exe
    nor --emit metadata is passed, or -Zno-link is used.
    bjorn3 committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    12a2941 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    aa51449 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2020

  1. Moved the main impl for FnCtxt to its own file.

    This is a solution to the file length being over 3000, something Clippy has a problem with.
    
    The other solution to the file length is
    1. to change the API of this struct by
    2. encapulating certain fields of the struct into other structs.
    Nicholas-Baron committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    21751fa View commit details
    Browse the repository at this point in the history
  2. Switch rustdoc from clean::Stability to rustc_attr::Stability

    This gives greater type safety and is less work to maintain on the
    rustdoc end.
    jyn514 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    cc0d140 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary Clean impl

    jyn514 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    85c0479 View commit details
    Browse the repository at this point in the history
  4. Move PartialOrd impl out of rustc

    Rustdoc's ordering requirements are probably not relevant to the rest of
    the compiler.
    jyn514 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    96b0446 View commit details
    Browse the repository at this point in the history
  5. bootstrap: only use compiler-builtins-c if they exist

    The assignment of `features` above was added in rust-lang#60981, but
    never used. Presumably the intent was to replace the string literal here
    with it.
    
    While I'm in the area, `compiler_builtins_c_feature` doesn't need to be
    a `String`.
    gburgessiv committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    ca5478a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    48291cf View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    16d0205 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. Configuration menu
    Copy the full SHA
    8487879 View commit details
    Browse the repository at this point in the history
  2. Remove dump_incremental_data

    bjorn3 committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    b620e49 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ce7c73c View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Configuration menu
    Copy the full SHA
    95221b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7beeb07 View commit details
    Browse the repository at this point in the history
  3. Add a target option for selecting a DWARF version

    Certain platforms need to limit the DWARF version emitted (oxs, *bsd). This
    change adds a dwarf_version entry to the options that allows a platform to
    specify the dwarf version to use. By default this option is none and the default
    DWARF version is selected.
    
    Also adds an option for printing Option<u32> json keys
    amshafer committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    4511f8b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Rollup merge of rust-lang#77765 - amshafer:master, r=petrochenkov

    Add LLVM flags to limit DWARF version to 2 on BSD
    
    This has been a thorn in my side for a while, I can finally generate flamegraphs of rust programs on bsd again. This fixes dtrace profiling on freebsd, I think it might help with lldb as well but I can't test that because my current rust-lldb setup is messed up.
    
    I'm limiting the dwarf version to 2 on all bsd's (netbsd/openbsd/freebsd) since it looks like this applies to all of them, but I have only tested on freebsd.
    
    Let me know if there's anything I can improve!
    
    ---
    Currently on FreeBSD dtrace profiling does not work and shows jumbled/incorrect
    symbols in the backtraces. FreeBSD does not support the latest versions of DWARF
    in dtrace (and lldb?) yet, and needs to be limited to DWARF2 in the same way as macos.
    
    This adds an is_like_bsd flag since it was missing. NetBSD/OpenBSD/FreeBSD all
    match this.
    
    This effectively copies rust-lang#11864 but targets FreeBSD instead of macos.
    Dylan-DPC committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    5962352 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#77788 - ssomers:btree_cleanup_gdb, r=Mark-S…

    …imulacrum
    
    BTreeMap: fix gdb provider on BTreeMap with ZST keys or values
    
    Avoid error when gdb is asked to inspect a BTreeMap or BTreeSet with a zero-sized type as key or value. And clean up.
    
    r? @Mark-Simulacrum
    Dylan-DPC committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    9c365a2 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#77795 - bjorn3:codegen_backend_interface_re…

    …factor, r=oli-obk
    
    Codegen backend interface refactor
    
    This moves several things away from the codegen backend to rustc_interface. There are a few behavioral changes where previously the incremental cache (incorrectly) wouldn't get finalized, but now it does. See the individual commit messages.
    Dylan-DPC committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    17ee28b View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#77808 - Nicholas-Baron:fn_ctxt_impl, r=matt…

    …hewjasper
    
    Moved the main `impl` for FnCtxt to its own file.
    
    Resolves rust-lang#77085 without breaking the API of the `FnCtxt` struct.
    
    This is a solution to the file length being over 3000 (see issue rust-lang#60302).
    
    The other solution to the file length is
    1. to change the API of this struct by
    2. encapulating certain fields of the struct into other structs.
    Dylan-DPC committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    becd6c6 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#77817 - jyn514:const-since, r=petrochenkov

    Switch rustdoc from `clean::Stability` to `rustc_attr::Stability`
    
    This gives greater type safety and is less work to maintain on the rustdoc end. It also makes rustdoc more consistent with rustc.
    Noticed this while working on rust-lang#76998.
    
    - Remove `clean::Stability` in favor of `rustc_attr::Stability`
    - Remove `impl Clean for Stability`; it's no longer necessary
    
    r? @GuillaumeGomez
    cc @petrochenkov
    Dylan-DPC committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    41146c1 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#77829 - gburgessiv:unused-features-var, r=a…

    …lexcrichton
    
    bootstrap: only use compiler-builtins-c if they exist
    
    The assignment of `features` above was added in rust-lang#60981, but
    never used. Presumably the intent was to replace the string literal here
    with it.
    
    While I'm in the area, `compiler_builtins_c_feature` doesn't need to be
    a `String`.
    
    I'm not entirely sure of a great way to locally test this -- `./x.py test`
    passed on my machine, but 🤷‍♂️.
    
    r? @alexcrichton
    Dylan-DPC committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    31799ba View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#77870 - camelid:intra-doc-super, r=jyn514

    Use intra-doc links for links to module-level docs
    
    r? @jyn514
    Dylan-DPC committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    ed34f82 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#77897 - GuillaumeGomez:cleanup-passes-mod, …

    …r=jyn514
    
    Move `Strip` into a separate rustdoc pass
    
    Just something which was bothering me lately. :)
    
    r? @jyn514
    Dylan-DPC committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    54151a6 View commit details
    Browse the repository at this point in the history