Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide help button on mobile #77979

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Hide help button on mobile #77979

merged 1 commit into from
Oct 15, 2020

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 15, 2020 •
edited
Loading

Addresses #77899.

This PR is just a quick fix for now: we're still debating about whether or not we want to display this help popup and if so, how. I'll open an issue once this PR is merged to discuss about it.

Before:

Screenshot from 2020-10-15 17-56-39

After:

Screenshot from 2020-10-15 17-55-06

r? @jyn514

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2020
@GuillaumeGomez GuillaumeGomez added A-rustdoc-ui Area: rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 15, 2020
@jyn514 jyn514 changed the title Hide help button Hide help button on mobile Oct 15, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 15, 2020

Instead of saying 'fixes' and opening a new issue, can you instead say "addresses" and put more comments on the same issue? That way all the discussion is in one place.

@GuillaumeGomez
Copy link
Member Author

Sure.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 15, 2020
Open
@jyn514
Copy link
Member

jyn514 commented Oct 15, 2020

Seems reasonable, but I don't know how to test this. Do you have screenshots of what it looks like after?

@GuillaumeGomez
Copy link
Member Author

I added a screenshot. :)

@jyn514
Copy link
Member

jyn514 commented Oct 15, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Oct 15, 2020

📌 Commit fce04fe has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2020
@GuillaumeGomez
Copy link
Member Author

@bors: rollup

@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 15, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2020
@bors
Auto merge of rust-lang#77981 - GuillaumeGomez:rollup-64ydc5g, r=Guil…
dd7fc54 
…laumeGomez

Rollup of 3 pull requests

Successful merges:

 - rust-lang#77963 (Fix link to foreign calling conventions)
 - rust-lang#77978 (Fix typo in documentation)
 - rust-lang#77979 (Hide help button on mobile)

Failed merges:

r? `@ghost`
@bors bors merged commit 16b1a6f into rust-lang:master Oct 15, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 15, 2020
@GuillaumeGomez GuillaumeGomez deleted the hide-help-button branch October 16, 2020 08:03
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 16, 2020
Closed
@jyn514
Copy link
Member

jyn514 commented Oct 18, 2020

@njasm can you open an issue? I agree it's less than ideal, but this PR didn't change very much in that area; it actually made it less crowded because ? no longer shows up.

@GuillaumeGomez
Copy link
Member Author

It's already an existing issue (I'm currently working on it).

@njasm
Copy link
Contributor

njasm commented Oct 19, 2020

@jyn514 yes. my bad. I wanted to comment on another issue, but got lost in the github android app navigation and posted here.

PS - I'll delete the comment since it's just bringing noise to this already merged PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rust-highfive @jyn514 @bors @njasm @rustbot