Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greatly improve display for small mobile devices screens #78084

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

GuillaumeGomez
Copy link
Member

Fixes #78014.

The biggest change being the "search bar". Instead of having everything on one line, I decided to move the search input on its own:

Screenshot from 2020-10-18 21-54-26

Another change is that now, we "break words" in the listing so that they don't grow too big:

Screenshot from 2020-10-18 21-57-17

r? @jyn514

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2020
@jyn514 jyn514 added A-rustdoc-ui Area: rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 19, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 19, 2020

Again, I'm not sure I'm the best person to review this ... maybe @ollie27 would be a better choice?

That said, the screeenshots do look a lot better :)

@GuillaumeGomez
Copy link
Member Author

Let's bring some docs.rs people too then. cc @Nemo157

@njasm
Copy link
Contributor

njasm commented Oct 19, 2020

the ss looks good to me 👍

@Nemo157
Copy link
Member

Nemo157 commented Oct 21, 2020

LGTM

@GuillaumeGomez
Copy link
Member Author

@bors: r=jyn514,Nemo157 rollup

@bors
Copy link
Contributor

bors commented Oct 21, 2020

📌 Commit 4e2c59a has been approved by jyn514,Nemo157

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2020
Rollup of 10 pull requests

Successful merges:

 - rust-lang#77420 (Unify const-checking structured errors for `&mut` and `&raw mut`)
 - rust-lang#77554 (Support signed integers and `char` in v0 mangling)
 - rust-lang#77976 (Mark inout asm! operands as used in liveness pass)
 - rust-lang#78009 (Haiku: explicitly set CMAKE_SYSTEM_NAME when cross-compiling)
 - rust-lang#78084 (Greatly improve display for small mobile devices screens)
 - rust-lang#78155 (Fix two small issues in compiler/rustc_lint/src/types.rs)
 - rust-lang#78156 (Fixed build failure of `rustfmt`)
 - rust-lang#78172 (Add test case for rust-lang#77062)
 - rust-lang#78188 (Add tracking issue number for pin_static_ref)
 - rust-lang#78200 (Add `ControlFlow::is_{break,continue}` methods)

Failed merges:

r? `@ghost`
@bors bors merged commit d9cf1f2 into rust-lang:master Oct 22, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 22, 2020
@GuillaumeGomez GuillaumeGomez deleted the improve-mobile-display branch October 22, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum width on mobile devices can be a bit problematic
7 participants