Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE when a future-incompat-report has its command-line level capped #78663

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Fix ICE when a future-incompat-report has its command-line level capped #78663

merged 1 commit into from
Nov 3, 2020
+34 −10

Commits on Nov 2, 2020

  1. Fix ICE when a future-incompat-report has its command-line level capped 

    Fixes rust-lang#78660

With PR rust-lang#75534 merged, we now run
more lint-related code for future-incompat-report, even when their final
level is Allow. Some lint-related code was not expecting `Level::Allow`,
and had an explicit panic.

This PR explicitly tracks the lint level set on the command line before
`--cap-lints` is applied. This is used to emit a more precise error
note (e.g. we don't say that `-W lint-name` was specified on the
command line just because a lint was capped to Warn). As a result, we
can now correctly emit a note that `-A` was used if we got
`Level::Allow` from the command line (before the cap is applied).
    @Aaron1011
    Aaron1011 committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    6c1f15f View commit details
    Browse the repository at this point in the history