inliner: Copy unevaluated constants only after successful inlining #78771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inliner copies the unevaluated constants from the callee body to the caller at the point where decision to inline is yet to be made. The constants will be unnecessary if inlining were to fail. Organize the code moving items from callee to the caller together in one place to avoid the issue.
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 6ca43ac has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 6, 2020
inliner: Copy unevaluated constants only after successful inlining Inliner copies the unevaluated constants from the callee body to the caller at the point where decision to inline is yet to be made. The constants will be unnecessary if inlining were to fail. Organize the code moving items from callee to the caller together in one place to avoid the issue.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 6, 2020
Rollup of 15 pull requests Successful merges: - rust-lang#74979 (`#![deny(unsafe_op_in_unsafe_fn)]` in sys/hermit) - rust-lang#78006 (Use Intra-doc links for std::io::buffered) - rust-lang#78167 (Fix unreachable sub-branch detection in or-patterns) - rust-lang#78514 (Allow using 1/2/3/4 for `x.py setup` options) - rust-lang#78538 (BTreeMap: document a curious assumption in test cases) - rust-lang#78559 (Add LLVM upgrades from 7 to 10 to RELEASES.md) - rust-lang#78666 (Fix shellcheck error) - rust-lang#78705 (Print a summary of which test suite failed) - rust-lang#78726 (Add link to rust website) - rust-lang#78730 (Expand explanation of reverse_bits) - rust-lang#78760 (`deny(invalid_codeblock_attributes)` for rustc_error_codes) - rust-lang#78771 (inliner: Copy unevaluated constants only after successful inlining) - rust-lang#78794 (rustc_expand: use collect_bang helper instead of manual reimplementation) - rust-lang#78795 (The renumber pass is long gone) - rust-lang#78798 (Fixing Spelling Typos) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inliner copies the unevaluated constants from the callee body to the
caller at the point where decision to inline is yet to be made. The
constants will be unnecessary if inlining were to fail.
Organize the code moving items from callee to the caller together in one
place to avoid the issue.